Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend depth overlay tests to include shader exported depth #95

Closed

Conversation

Zorro666
Copy link
Owner

@Zorro666 Zorro666 commented Aug 13, 2023

Description

Extend the depth overlay tests to support Issue 2858

This is the final PR in the sequence of PRs which all together complete the implementation of the feature.
This final PR extends the automated overlay tests GL_Overlay_Test, D3D11_Overlay_Test, D3D12_Overlay_Test, VK_Overlay_Test. The tests have been extended to use a pixel shader to write out depth 0.0 for a small rectangle just bottom-left of the centre.

This also includes a minor tweak to the D3D12 overlay initialisation code based on a compile error from clang on similar code used in the Vulkan overlay initialisation.

Testing

  • Windows GL_Overlay_Test, D3D11_Overlay_Test, D3D12_Overlay_Test, VK_Overlay_Test.
  • Linux GL_Overlay_Test, VK_Overlay_Test.

@Zorro666 Zorro666 force-pushed the support-shader-exported-depth-in-depth-test-overlay branch 5 times, most recently from 870d7ba to 11440c1 Compare August 26, 2023 08:17
@Zorro666 Zorro666 force-pushed the support-shader-exported-depth-in-depth-test-overlay branch 12 times, most recently from a4cd1f7 to 7b63f9c Compare September 10, 2023 15:58
@Zorro666 Zorro666 force-pushed the support-shader-exported-depth-in-depth-test-overlay branch 5 times, most recently from c05e338 to 3dbcaf1 Compare September 20, 2023 07:02
@Zorro666 Zorro666 force-pushed the support-shader-exported-depth-in-depth-test-overlay branch 2 times, most recently from 7757367 to e3752c1 Compare October 2, 2023 08:08
@Zorro666 Zorro666 force-pushed the support-shader-exported-depth-in-depth-test-overlay branch 6 times, most recently from 1710703 to e426a5f Compare October 6, 2023 19:07
@Zorro666 Zorro666 force-pushed the support-shader-exported-depth-in-depth-test-overlay branch from e426a5f to 2341255 Compare October 9, 2023 15:21
@Zorro666 Zorro666 force-pushed the support-shader-exported-depth-in-depth-test-overlay branch 2 times, most recently from 61d6624 to e607959 Compare October 25, 2023 14:13
@Zorro666 Zorro666 force-pushed the support-shader-exported-depth-in-depth-test-overlay branch 3 times, most recently from 8e1a33f to e5ccab1 Compare November 7, 2023 17:14
@Zorro666 Zorro666 force-pushed the support-shader-exported-depth-in-depth-test-overlay branch 9 times, most recently from 61b45f7 to 53e1f23 Compare November 14, 2023 09:17
@Zorro666 Zorro666 changed the title Support shader exported depth in depth test overlay Extend depth overlay tests to include shader exported depth Nov 16, 2023
@Zorro666 Zorro666 force-pushed the support-shader-exported-depth-in-depth-test-overlay branch from 53e1f23 to cefd689 Compare November 16, 2023 09:50
Support shader exported depth by replaying using the capture pixel shader to determine passing pixels
@Zorro666 Zorro666 force-pushed the support-shader-exported-depth-in-depth-test-overlay branch from cefd689 to b218adb Compare November 27, 2023 16:36
@Zorro666 Zorro666 force-pushed the support-shader-exported-depth-in-depth-test-overlay branch from b218adb to 84fab2b Compare November 27, 2023 16:54
@Zorro666
Copy link
Owner Author

baldurk#3153

@Zorro666 Zorro666 closed this Nov 27, 2023
@Zorro666 Zorro666 deleted the support-shader-exported-depth-in-depth-test-overlay branch December 5, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant