Add D3D12 test failed callback for pixel history #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zorro666
reviewed
Nov 6, 2023
This callback determines which tests passed or failed for a given draw during pixel history. The set of tests mirrors the Vulkan implementation, with some adjustments for D3D12 capabilities. The code for updating PixelModification structs during pixel history is included as well since they're related.
skarolewics
force-pushed
the
pixelhistory2
branch
from
2210345 to
d71d6e8
Compare
|
Thank you again for the code/feature and making small tweaks during the landing process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This callback determines which tests passed or failed for a given draw during pixel history. The set of tests mirrors the Vulkan implementation, with some adjustments for D3D12 capabilities. The code for updating PixelModification structs during pixel history is included as well since they're related.