Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vb values to rule files #154

Merged
merged 5 commits into from
Jun 27, 2022
Merged

add vb values to rule files #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8144dfc
add vb values to system.web.json
cslong Jun 3, 2022
d6fcfb0
fix: validation name for vb
cslong Jun 6, 2022
31360ae
add more vb values for most owin recommendations
cslong Jun 8, 2022
0c195e3
add more vb updates
cslong Jun 9, 2022
3d2bb71
vb update to remaining owin file
cslong Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions recommendation/microsoft.aspnet.identity.owin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@
"ActionValidation": {
"Contains": "using Microsoft.AspNetCore.Identity;",
"NotContains": ""
},
"VbActionValidation": {
"Contains": "Imports Microsoft.AspNetCore.Identity",
"NotContains": ""
}
},
{
Expand All @@ -67,6 +71,10 @@
"ActionValidation": {
"Contains": "",
"NotContains": "using Microsoft.AspNet.Identity.Owin;"
},
"VbActionValidation": {
"Contains": "",
"NotContains": "Imports Microsoft.AspNet.Identity.Owin"
}
}
]
Expand Down
34 changes: 34 additions & 0 deletions recommendation/microsoft.owin.hosting.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@
"ActionValidation": {
"Contains": "using Microsoft.AspNetCore.Hosting;",
"NotContains": ""
},
"VbActionValidation": {
"Contains": "Imports Microsoft.AspNetCore.Hosting",
"NotContains": ""
}
},
{
Expand All @@ -79,6 +83,10 @@
"ActionValidation": {
"Contains": "using Microsoft.AspNetCore.Server.Kestrel;",
"NotContains": ""
},
"VbActionValidation": {
"Contains": "Imports Microsoft.AspNetCore.Server.Kestrel",
"NotContains": ""
}
},
{
Expand All @@ -89,6 +97,10 @@
"ActionValidation": {
"Contains": "",
"NotContains": "using Microsoft.Owin.Hosting;"
},
"VbActionValidation": {
"Contains": "",
"NotContains": "Imports Microsoft.Owin.Hosting"
}
},
{
Expand All @@ -99,6 +111,10 @@
"ActionValidation": {
"Contains": "",
"NotContains": "using Owin;"
},
"VbActionValidation": {
"Contains": "",
"NotContains": "Imports Owin"
}
}
]
Expand Down Expand Up @@ -153,11 +169,20 @@
"comment": "Replace Microsoft.Owin.Hosting.WebApp.Start with WebHostBuilder such as: var host = new WebHostBuilder().UseKestrel().UseUrls(URL_HERE).UseStartup<Startup>().Build(); host.Start(); Start options can be added into the new format as needed.",
"dontUseCTAPrefix": ""
},
"VbValue": {
"comment": "Replace Microsoft.Owin.Hosting.WebApp.Start with WebHostBuilder. Start options can be added into the new format as needed.",
"dontUseCTAPrefix": ""
},
"Description": "Add a comment to explain how to replace WebApp.Start.",
"ActionValidation": {
"Contains": "Replace Microsoft.Owin.Hosting.WebApp.Start with WebHostBuilder such as: var host = new WebHostBuilder().UseKestrel().UseUrls(URL_HERE).UseStartup<Startup>().Build(); host.Start(); Start options can be added into the new format as needed.",
"NotContains": "",
"CheckComments": "True"
},
"VbActionValidation": {
"Contains": "Replace Microsoft.Owin.Hosting.WebApp.Start with WebHostBuilder. Start options can be added into the new format as needed.",
"NotContains": "",
"CheckComments": "True"
}
}
]
Expand Down Expand Up @@ -212,11 +237,20 @@
"comment": "Replace Microsoft.Owin.Hosting.WebApp.Start with WebHostBuilder such as: var host = new WebHostBuilder().UseKestrel().UseUrls(URL_HERE).UseStartup<Startup>().Build(); host.Start(); UseStartup can contain the TStartup class used before.",
"dontUseCTAPrefix": ""
},
"VbValue": {
"comment": "Replace Microsoft.Owin.Hosting.WebApp.Start with WebHostBuilder. UseStartup can contain the TStartup class used before.",
"dontUseCTAPrefix": ""
},
"Description": "Add a comment to explain how to replace WebApp.Start.",
"ActionValidation": {
"Contains": "Replace Microsoft.Owin.Hosting.WebApp.Start with WebHostBuilder such as: var host = new WebHostBuilder().UseKestrel().UseUrls(URL_HERE).UseStartup<Startup>().Build(); host.Start(); UseStartup can contain the TStartup class used before.",
"NotContains": "",
"CheckComments": "True"
},
"VbActionValidation": {
"Contains": "Replace Microsoft.Owin.Hosting.WebApp.Start with WebHostBuilder. UseStartup can contain the TStartup class used before.",
"NotContains": "",
"CheckComments": "True"
}
}
]
Expand Down
19 changes: 18 additions & 1 deletion recommendation/microsoft.owin.infrastructure.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@
"ActionValidation": {
"Contains": "using Microsoft.AspNetCore.WebUtilities;",
"NotContains": ""
},
"VbActionValidation": {
"Contains": "Imports Microsoft.AspNetCore.WebUtilities",
"NotContains": ""
}
},
{
Expand All @@ -67,6 +71,10 @@
"ActionValidation": {
"Contains": "",
"NotContains": "using Microsoft.Owin.Infrastructure;"
},
"VbActionValidation": {
"Contains": "",
"NotContains": "Imports Microsoft.Owin.Infrastructure"
}
}
]
Expand Down Expand Up @@ -121,12 +129,21 @@
"comment": "Please replace your parameters as the AddQueryString(string, string) method has been deprecated and you must either use the AddQueryString(string, string, string) method or the AddQueryString(string, System.Collections.Generic.IDictionary<string, string>) method.",
"dontUseCTAPrefix": ""
},
"VbValue": {
"comment": "Please replace your parameters as the AddQueryString(string, string) method has been deprecated and you must either use the AddQueryString(string, string, string) method or the AddQueryString(string, System.Collections.Generic.IDictionary(Of string, string)) method.",
"dontUseCTAPrefix": ""
},
"Description": "Add a comment to explain how to replace the AddQueryString(string, string) invocation.",
"ActionValidation": {
"Contains": "Please replace your parameters as the AddQueryString(string, string) method has been deprecated and you must either use the AddQueryString(string, string, string) method or the AddQueryString(string, System.Collections.Generic.IDictionary<string, string>) method.",
"NotContains": "",
"CheckComments": "True"
}
},
"VbActionValidation": {
"Contains": "Please replace your parameters as the AddQueryString(string, string) method has been deprecated and you must either use the AddQueryString(string, string, string) method or the AddQueryString(string, System.Collections.Generic.IDictionary(Of string, string)) method",
"NotContains": "",
"CheckComments": "True"
}
},
{
"Name": "ReplaceMethodOnly",
Expand Down
Loading