Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vb values to rule files #154

Merged
merged 5 commits into from
Jun 27, 2022
Merged

add vb values to rule files #154

merged 5 commits into from
Jun 27, 2022

Conversation

cslong
Copy link
Contributor

@cslong cslong commented Jun 3, 2022

Description of changes:
Add visual basic values and validation to recommendation files

Tested by putting into the temp rules folder in CTA and ensuring all unit test pass.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cslong cslong marked this pull request as draft June 3, 2022 18:32
recommendation/system.web.json Outdated Show resolved Hide resolved
@saikiranakula-amzn
Copy link
Contributor

looks good to me

@cslong cslong changed the title add vb values to system.web.json add vb values to rule files Jun 9, 2022
@cslong cslong marked this pull request as ready for review June 9, 2022 22:00
@cslong cslong merged commit 9049555 into master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants