Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Caching from integ test #1517

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+2 −136
Open

Removing Caching from integ test #1517

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
835b7ad
removing cacheing from integ tests
Paramadon Jan 23, 2025
16648e5
fixing cache if success
Paramadon Jan 24, 2025
66a902e
removing caching
Paramadon Jan 24, 2025
0fa2f10
removing caching from tests
Paramadon Jan 24, 2025
fe5fcc2
fixing
Paramadon Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/ec2-integration-test.yml
View file
Open in desktop
Paramadon marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,6 @@ jobs:
aws-region: ${{inputs.region}}
role-duration-seconds: ${{ env.TERRAFORM_AWS_ASSUME_ROLE_DURATION }}

- name: Cache if success
id: cache_if_success
uses: actions/cache@v3
with:
path: go.mod
key: ${{inputs.region}}-${{ github.sha }}-${{ matrix.arrays.os }}-${{ matrix.arrays.arc }}-${{ matrix.arrays.test_dir }}

- name: Echo Test Info
run: |
echo run cache_if_success os ${{ matrix.arrays.os }} arc ${{ matrix.arrays.arc }} test dir ${{ matrix.arrays.test_dir }}
Paramadon marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -85,7 +78,6 @@ jobs:

# nick-fields/retry@v2 starts at base dir
- name: Terraform apply
if: steps.cache_if_success.outputs.cache-hit != 'true'
uses: nick-fields/retry@v2
with:
max_attempts: 2
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/eks-e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ jobs:
run: terraform --version

- name: Terraform apply
if: steps.cache_if_success.outputs.cache-hit != 'true'
uses: nick-fields/retry@v2
with:
max_attempts: 3
Expand Down
43 changes: 2 additions & 41 deletions .github/workflows/integration-test.yml
View file
Open in desktop
Paramadon marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,7 @@ jobs:
aws-region: us-west-2
role-duration-seconds: ${{ env.TERRAFORM_AWS_ASSUME_ROLE_DURATION }}

- name: Cache if success
id: cf-integration-test
uses: actions/cache@v2
with:
path: go.mod
key: "cf-integration-${{ github.sha }}-test"

- name: Test cf
if: steps.ec2-linux-integration-test.outputs.cache-hit != 'true'
run: |
cd test/test/cloudformation
go test -timeout 1h -package_path=s3://${S3_INTEGRATION_BUCKET}/integration-test/binary/${{ github.sha }}/linux/amd64/amazon-cloudwatch-agent.rpm -iam_role=${CF_IAM_ROLE} -key_name=${CF_KEY_NAME} -metric_name=mem_used_percent
Expand Down Expand Up @@ -244,13 +236,6 @@ jobs:
aws-region: us-west-2
role-duration-seconds: ${{ env.TERRAFORM_AWS_ASSUME_ROLE_DURATION }}

- name: Cache if success
id: ec2-linux-integration-test
uses: actions/cache@v3
with:
path: go.mod
key: ec2-nvidia-integration-test-${{ github.sha }}-${{ matrix.arrays.os }}-${{ matrix.arrays.arc }}-${{ matrix.arrays.test_dir }}

- name: Echo Test Info
run: echo run on ec2 instance os ${{ matrix.arrays.os }} arc ${{ matrix.arrays.arc }} test dir ${{ matrix.arrays.test_dir }}

Expand All @@ -262,7 +247,7 @@ jobs:

# nick-fields/retry@v2 starts at base dir
- name: Terraform apply
if: ${{ matrix.arrays.family == 'linux' && steps.ec2-nvidia-integration-test.outputs.cache-hit != 'true' }}
if: ${{ matrix.arrays.family == 'linux' }}
uses: nick-fields/retry@v2
with:
max_attempts: 3
Expand Down Expand Up @@ -295,7 +280,7 @@ jobs:
terraform destroy -auto-approve && exit 1
fi
- name: Terraform apply
if: ${{ matrix.arrays.family == 'window' && steps.ec2-nvidia-integration-test.outputs.cache-hit != 'true' }}
if: ${{ matrix.arrays.family == 'window' }}
uses: nick-fields/retry@v2
with:
max_attempts: 3
Expand Down Expand Up @@ -465,13 +450,6 @@ jobs:
aws-region: us-west-2
role-duration-seconds: ${{ env.TERRAFORM_AWS_ASSUME_ROLE_DURATION }}

- name: Cache if success
id: ec2-win-integration-test
uses: actions/cache@v3
with:
path: go.mod
key: ec2-win-integration-test-${{ github.sha }}-${{ matrix.arrays.os }}-${{ matrix.arrays.arc }}-${{ matrix.arrays.test_dir }}

- name: Echo Test Info
run: echo run on ec2 instance os ${{ matrix.arrays.os }} use ssm ${{ matrix.arrays.useSSM }} test ${{ matrix.arrays.test_dir }}

Expand All @@ -483,7 +461,6 @@ jobs:

# nick-fields/retry@v2 starts at base dir
- name: Terraform apply
if: steps.ec2-win-integration-test.outputs.cache-hit != 'true'
uses: nick-fields/retry@v2
with:
max_attempts: 3
Expand Down Expand Up @@ -550,13 +527,6 @@ jobs:
aws-region: us-west-2
role-duration-seconds: ${{ env.TERRAFORM_AWS_ASSUME_ROLE_DURATION }}

- name: Cache if success
id: ec2-mac-integration-test
uses: actions/cache@v3
with:
path: go.mod
key: ec2-mac-integration-test-${{ github.sha }}-${{ matrix.arrays.os }}-${{ matrix.arrays.arc }}-${{ matrix.arrays.test_dir }}

- name: Echo OS
run: echo run on ec2 instance os ${{ matrix.arrays.os }}

Expand All @@ -568,7 +538,6 @@ jobs:

# nick-fields/retry@v2 starts at base dir
- name: Terraform apply
if: steps.ec2-mac-integration-test.outputs.cache-hit != 'true'
uses: nick-fields/retry@v2
with:
max_attempts: 3
Expand Down Expand Up @@ -706,7 +675,6 @@ jobs:
run: terraform --version

- name: Terraform apply
if: steps.ecs-ec2-integration-test.outputs.cache-hit != 'true'
uses: nick-fields/retry@v2
with:
max_attempts: 3
Expand Down Expand Up @@ -793,7 +761,6 @@ jobs:
run: terraform --version

- name: Terraform apply
if: steps.ecs-fargate-integration-test.outputs.cache-hit != 'true'
uses: nick-fields/retry@v2
with:
max_attempts: 3
Expand Down Expand Up @@ -875,7 +842,6 @@ jobs:
run: terraform --version

- name: Terraform apply
if: steps.eks-ec2-integration-test.outputs.cache-hit != 'true'
uses: nick-fields/retry@v2
with:
max_attempts: 2
Expand Down Expand Up @@ -961,7 +927,6 @@ jobs:
run: terraform --version

- name: Terraform apply
if: steps.eks-ec2-integration-test.outputs.cache-hit != 'true'
uses: nick-fields/retry@v2
with:
max_attempts: 3
Expand Down Expand Up @@ -1040,7 +1005,6 @@ jobs:
run: terraform --version

- name: Terraform apply
if: steps.performance-tracking.outputs.cache-hit != 'true'
uses: nick-fields/retry@v2
with:
max_attempts: 1
Expand Down Expand Up @@ -1112,7 +1076,6 @@ jobs:
run: terraform --version

- name: Terraform apply
if: steps.performance-tracking.outputs.cache-hit != 'true'
uses: nick-fields/retry@v2
with:
max_attempts: 1
Expand Down Expand Up @@ -1187,7 +1150,6 @@ jobs:
run: echo run on ec2 instance os ${{ matrix.arrays.os }} arc ${{ matrix.arrays.arc }} test dir ${{ matrix.arrays.test_dir }} values per minute ${{ matrix.arrays.values_per_minute }}

- name: Terraform apply
if: steps.stress-tracking.outputs.cache-hit != 'true'
uses: nick-fields/retry@v2
with:
max_attempts: 1
Expand Down Expand Up @@ -1261,7 +1223,6 @@ jobs:
run: echo run on ec2 instance os ${{ matrix.arrays.os }} arc ${{ matrix.arrays.arc }} test dir ${{ matrix.arrays.test_dir }} values per minute ${{ matrix.arrays.values_per_minute }}

- name: Terraform apply
if: steps.ec2-win-stress-tracking-test.outputs.cache-hit != 'true'
uses: nick-fields/retry@v2
with:
max_attempts: 1
Expand Down
Loading