Removing Caching from integ test #1517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisStark
reviewed
Jan 23, 2025
musa-asad
reviewed
Jan 24, 2025
musa-asad
approved these changes
Jan 24, 2025
TravisStark
previously approved these changes
Jan 24, 2025
jefchien
reviewed
Jan 24, 2025
jefchien
requested changes
Jan 24, 2025
There was a problem hiding this comment.
I'm still seeing some caches https://github.com/aws/amazon-cloudwatch-agent/actions/caches?query=branch%3ARemovingCaching. The build ones are fine, but there shouldn't be any remaining test ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Caching was intially put in place to reduce the number of tests that needed to be re-run on partial failures in an effort to speed up testing. It currently is put in place to skip passing tests on re-runs. But since GitHub workflows supports re-running failed jobs, which already covers the purpose of the caching. Caching conflicts have also resulted in false positives for passing tests like the stress tests.
Description of changes
This pr removes caching to avoid false negatives.
Integration test run: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/12938647885