-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EKS E2E Testing Workflow #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Musa <[email protected]>
musa-asad
changed the title
Implement E2E testing framework workflow.
Implement E2E testing framework for EKS
Dec 2, 2024
musa-asad
changed the title
Implement E2E testing framework for EKS
Implement E2E testing workflow for EKS
Dec 2, 2024
musa-asad
changed the title
Implement E2E testing workflow for EKS
Implement E2E Testing Workflow for EKS
Dec 2, 2024
musa-asad
commented
Dec 2, 2024
musa-asad
changed the title
Implement E2E Testing Workflow for EKS
Implement EKS E2E Testing Workflow
Dec 2, 2024
musa-asad
commented
Dec 5, 2024
okankoAMZ
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
dricross
previously approved these changes
Dec 13, 2024
okankoAMZ
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but would like to see it tested with the test repo after, the test repo is merged
dricross
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We aim to enhance our testing framework to support end-to-end testing of various
helm-charts
values and allow the use of custom branches for the agent, operator, and helm-charts repositories to enable testing of different configurations and prevent regressions to verify Kubernetes resource creation/deletion and metric emission.Description of changes
Co-PR: aws/amazon-cloudwatch-agent-test#434.
Important
Updated
build-test-artifacts.yml
due to failing workflow run, which tried to run the integration tests: View Workflow Run #12324314762. It isn't problematic to include this as an option.e2e-test.yml
workflow to run end-to-end tests with configurable inputs forregion
,operator_branch
, andhelm_charts_branch
.e2e-build.yml
intoe2e-test.yml
to prevent calling more than three nested workflows.eks-e2e-test.yml
as a reusable workflow for EKS cluster Terraform creation.GenerateTestMatrix
job, similar to the one inintegration-test.yml
, to generate test configurations using a Go generator script from theamazon-cloudwatch-agent-test
repository.An example job for the re-usable workflow:
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
View Workflow Run #12337417856
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint