-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EKS E2E Terraform Framework #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisStark
previously approved these changes
Dec 11, 2024
okankoAMZ
reviewed
Dec 12, 2024
dricross
reviewed
Dec 13, 2024
This reverts commit e0fbd7e.
dricross
previously approved these changes
Dec 13, 2024
okankoAMZ
reviewed
Dec 16, 2024
okankoAMZ
reviewed
Dec 16, 2024
okankoAMZ
previously approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking comments. Looks good
okankoAMZ
approved these changes
Dec 16, 2024
dricross
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We aim to enhance our testing framework to support end-to-end testing of various
helm-charts
values and allow the use of custom branches for the agent, operator, and helm-charts repositories to enable testing of different configurations and prevent regressions to verify Kubernetes resource creation/deletion and metric emission.Description of changes
Co-PR: aws/amazon-cloudwatch-agent#1445.
amazon-cloudwatch-agent
package.MetaData
andMetaDataStrings
structs inenvironment/metadata.go
to support EKS E2E testing parameters.registerEKSE2ETestData
function to register new command-line flags for EKS E2E testing.main.tf
,providers.tf
,variables.tf
) interraform/eks/e2e
to set up EKS clusters for testing.eks_e2e
test configuration ingenerator/test_case_generator.go
. Separated it intotestTypeToTestConfigE2E
in order to avoid generating the non-E2E matrix files in the E2E workflow.ConfigureAWSClients
function inutil/awsservice/constant.go
to allow custom region changes for AWS clients.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Successfully deploys the CWA Operator, CWA, and Sample Application:
Also utilizes the correct images.