chore(metrics): use geth metrics package and delete local metrics #1422
Conversation
qdm12
force-pushed
the
qdm12/libevm/metrics
branch
2 times, most recently
from
34e9afd to
8c8514c
Compare
metrics/prometheus/prometheus.go
Outdated
| default: | ||
| return nil, fmt.Errorf("metric type is not supported: %T", metric) |
There was a problem hiding this comment.
I took the liberty to change this to return an error (instead of silently ignoring it) on an unsupported type to prevent in the future to define new types and forget to add the implementation in the switch here.
qdm12
force-pushed
the
qdm12/libevm/metrics
branch
from
7c08815 to
15866c8
Compare
qdm12
changed the title
qdm12
force-pushed
the
qdm12/libevm/metrics
branch
from
15866c8 to
769d5fc
Compare
- Bring over refactoring and fixes done in ava-labs/libevm#103 - Bring over test refactoring done in ava-labs/libevm#103
Signed-off-by: Quentin McGaw <[email protected]>
Signed-off-by: Quentin McGaw <[email protected]>
- add exported comments - rename `g` to `gatherer` in test - Format copyright as it as ™️ - Remove TODO
qdm12
force-pushed
the
qdm12/libevm/metrics
branch
from
769d5fc to
b008bf7
Compare
There was a problem hiding this comment.
Looks good! The subnet dashboard is now populated with metrics for the load test e2e job:
A random PR doesn't show any metrics on the subnets dashboard for the same job:
Ah, let me check if I can revert it to no-metric, and open another PR (based off this one I suppose) to enable metrics. |
Why this should be merged
Contribution to the libevm effort.
Note there are the same changes for both coreth and subnet-evm, but they should not be part of libevm since these are extra features specific to subnet-evm/coreth, even if they're the same for both.
How this works
Comparing the following:
mastervs corethmaster: subnet-evm is missing the extra file https://github.com/ava-labs/coreth/blob/b6b4dfbc4bfc7f17e4cfe5f3c0fb44944176c884/metrics/init_test.go (which is present in geth as well)mastervs gethv1.13.14: subnet-evm has many deletions, very few minor unneeded changes and the new non-conflicting filemetrics/prometheus/prometheus.goTherefore:
metricsare deleted EXCEPT:metrics/prometheus/prometheus.gometrics/prometheus/prometheus_test.gometrics/prometheus/interfaces.go(new file added whilst refactoring)metrics.Enabledis set to true ininitializeMetricsHow this was tested
CI passing
Need to be documented?
No
Need to update RELEASES.md?
Not really, since it should not change anything 🙏