-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(metrics/prometheus): add files needed for coreth and subnet-evm #103
Conversation
- replace `Gatherer` function with `NewGatherer` to export `gatherer` and return a concrete `*Gatherer` type - fix slice out of range bug in metrics.ResettingTimer case - change behavior to return an error if metric type is not supported - define local narrower registry interface - rework switch for metric families to be simpler
Why does this need to be in I see that it's still in draft so I may have checked too early, but I also want to save you doing unnecessary work. |
- Bring over refactoring and fixes done in ava-labs/libevm#103 - Bring over test refactoring done in ava-labs/libevm#103
- Bring over refactoring and fixes done in ava-labs/libevm#103 - Bring over test refactoring done in ava-labs/libevm#103
- Bring over refactoring and fixes done in ava-labs/libevm#103 - Bring over test refactoring done in ava-labs/libevm#103
- Bring over refactoring and fixes done in ava-labs/libevm#103 - Bring over test refactoring done in ava-labs/libevm#103
- Bring over refactoring and fixes done in ava-labs/libevm#103 - Bring over test refactoring done in ava-labs/libevm#103
Closed since not needed - coreth and subnet-evm do import libevm, but define their own metrics/prometheus files for their own custom code (even if it's the same for now) |
- Bring over refactoring and fixes done in ava-labs/libevm#103 - Bring over test refactoring done in ava-labs/libevm#103
- Bring over refactoring and fixes done in ava-labs/libevm#103 - Bring over test refactoring done in ava-labs/libevm#103
- Bring over refactoring and fixes done in ava-labs/libevm#103 - Bring over test refactoring done in ava-labs/libevm#103
Why this should be merged
So that coreth and subnet-evm can use the metrics package from libevm instead of defining/depending on their own local metrics package.
➡️ coreth PR using this branch
➡️ subnet-evm PR using this branch
Also fixes and refactoring.
How this works
metrics/prometheus/prometheus.libevm.go
containing extra (non conflicting) code needed for coreth and subnet-evmGatherer
renamed toNewGatherer
to exportgatherer
and return a concrete*Gatherer
type ("accept interfaces, return concrete types")metrics.ResettingTimer
switch caseRegistry
interface inmetrics/prometheus/interfaces.libevm.go
ptrTo
generic functionHow this was tested
CI passing here, in coreth's PR and subnet-evm's PR