Fix trailing slash #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-i18n-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for astro-i18n ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
florian-lefebvre
approved these changes
Sep 5, 2024
|
Funnily enough I think this caused #38 😆 |
|
Yeah that's likely, if you find how to fix it I take it 😆 |
nojaf
commented
Oct 7, 2024
| @@ -11,7 +11,7 @@ const extractLocaleFromUrl = (pathname: string) => { | |||
| } else if (options.strategy === "prefixExceptDefault") { | |||
| if ( | |||
| locale !== options.defaultLocale && | |||
| pathname.startsWith(`/${locale}/`) | |||
| pathname.startsWith(`/${locale}`) | |||
There was a problem hiding this comment.
@amosbastian perhaps you can try to use
const locale = 'fr';
const regex = new RegExp(`^/${locale}(/|$|/[^/]+)`);
console.log(regex.test('/fr')); // true
console.log(regex.test('/fr/')); // true
console.log(regex.test('/fr/boo')); // true
console.log(regex.test('/freedom')); // falseinstead of pathname.startsWith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @florian-lefebvre, I believe I have found a fix for #24.
The problem was only ever happening on the root of a locale without a trailing slash.
F.ex.
http://localhost:4322/fr.So I remove the trailing slash in the middleware.