Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take trailing slash into account #24

Closed
florian-lefebvre opened this issue May 10, 2024 · 7 comments · Fixed by #34
Closed

Take trailing slash into account #24

florian-lefebvre opened this issue May 10, 2024 · 7 comments · Fixed by #34
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@florian-lefebvre
Copy link
Member

No description provided.

@florian-lefebvre florian-lefebvre added bug Something isn't working enhancement New feature or request labels May 10, 2024
@nojaf
Copy link
Contributor

nojaf commented Jun 10, 2024

Hi there, shot in the dark, but right now I don't get my language when I browser to /fr only when I go to /fr/.

image

Would this related to this bug?

@florian-lefebvre
Copy link
Member Author

mmh I'm not sure because you don't have a special trailingSlash configuration. Would you mind providing a minimal reproduction? (in a repository, there are issues with Stackblitz)

@nojaf
Copy link
Contributor

nojaf commented Jun 11, 2024

This is what I have so far: https://github.com/nojaf/astro-translations-repro

@dsijakovski98
Copy link

Having the same issue, cannot get locales to load for /mk only for /mk/.
Also, looks like it is the same behaviour in the Demo app.

If can be made so that it recognizes the locale without the trailing slash, would be awesome 🙏

@amosbastian
Copy link

Same as above. It only loads the default locale's translations if you have trailingSlash set to e.g. never. Would be great to get this fixed 🙏

@florian-lefebvre
Copy link
Member Author

If someone wants to contribute this fix, please do! I don't have near plans to address it

@florian-lefebvre florian-lefebvre added the help wanted Extra attention is needed label Sep 3, 2024
@nojaf
Copy link
Contributor

nojaf commented Sep 4, 2024

Sounds reasonable, any pointers or steps on how one would debug or run this locally?

@nojaf nojaf mentioned this issue Sep 5, 2024
@florian-lefebvre florian-lefebvre linked a pull request Sep 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants