chore: bump to rust version 1.83 #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci
ethanoroshiba
requested review from
a team,
joroshiba and
noot
as code owners
This was referenced Dec 6, 2024
Fraser999
approved these changes
Dec 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
…1863) ## Summary Changed block channel to use boxed sequencer blocks. ## Background Running clippy with Rust 1.83.0 in #1857 triggered a lint for large error variant in the send methods for `BlobSubmitterHandle`. Large enum variants (including in Results) should be avoided because they are only as small as their largest variant: https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err. Creating the channel with a boxed block tackles this problem at its source. ## Changes - Boxed `SequencerBlock` in `BlobSubmitterHandle`, which tackles the problem of potentially large send errors at its source. ## Testing Passing all tests ## Changelogs No updates required. ## Breaking Changes Overridden code freeze since this is a very small, non breaking change that shouldn't have any bearing since our previous audit. ## Related Issues closes #1860
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
## Summary Changed firm block channel to use boxed `ReconstructedBlock`. ## Background A large error variant lint was triggered when running clippy with Rust 1.83.0 in #1857 due to send errors returning the whole block. Large enum variants should be avoided because enums are only as small as their largest variant: https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant. Changing the channel to consist of a boxed block instead solves this problem at its source. ## Changes - Changed firm block channel to use boxed `ReconstructedBlock` instead of it being unboxed. ## Testing Passing all tests. ## Changelogs No updates needed. ## Breaking Changes Overridden code freeze since this is a very small, non breaking change that shouldn't have any bearing since our previous audit. ## Related Issues closes #1858
joroshiba
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumped MSRV to 1.83 and made small changes to appease new Clippy lints.
Background
Rust 1.83 solves some bizarre Clippy false positives, improved lints also revealed some nit improvement points. Bumping MSRV also doesn't have a huge cost, since we don't have many downstream users.
Changes
Testing
Passing all tests.
Changelogs
Changelogs updated for crates which have already been released.
Related Issues
closes #1580