chore(sequencer-relayer): change blob submitter to use boxed blocks #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanoroshiba
added
sequencer-relayer
SuperFluffy
reviewed
Dec 9, 2024
ethanoroshiba
changed the title
SuperFluffy
reviewed
Dec 10, 2024
| @@ -276,14 +276,19 @@ impl Relayer { | |||
| } | |||
|
|
|||
| #[instrument(skip_all, fields(%height))] | |||
| #[expect( | |||
There was a problem hiding this comment.
I mean, you could just give this an alias, type ForwardingFut = Fuse<BoxFuture<...>>
Fraser999
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed block channel to use boxed sequencer blocks.
Background
Running clippy with Rust 1.83.0 in #1857 triggered a lint for large error variant in the send methods for
BlobSubmitterHandle. Large enum variants (including in Results) should be avoided because they are only as small as their largest variant: https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err. Creating the channel with a boxed block tackles this problem at its source.Changes
SequencerBlockinBlobSubmitterHandle, which tackles the problem of potentially large send errors at its source.Testing
Passing all tests
Changelogs
No updates required.
Breaking Changes
Overridden code freeze since this is a very small, non breaking change that shouldn't have any bearing since our previous audit.
Related Issues
closes #1860