36 update charts for gtm #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since `GOOGLE_TAG_MANAGER_ID` is being referenced through an environment variable, it needed to be added as a deployment variable as well. we only need this value accessible in production, so I was able to remove it from the local env. the value should return as "undefined" and "" in the local and staging environments, respectively. related: #37
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I deployed this branch to main, but the gtm id still wasn't picked up. I'm thinking that the deploy updates need to actually be in |
|
Not able to give an code review/approval after merge |
alishaevn
added a commit
that referenced
this pull request
Jan 24, 2024
I thought that the reason the GTM ID wasn't showing on production after deploying my branch (#38) to production was because the deploy changes needed to be in main to take effect. however, after merging the above to main and deploying again, the GTM ID still doesn't show up. I now believe the issue is related to the `NEXT_PUBLIC` prefix. Added it to the GTM ID so that the client should be able to pick up the variable.
Merged
Closed
1 task
alishaevn
added a commit
to assaydepot/webstore
that referenced
this pull request
Jan 24, 2024
I thought that the reason the GTM ID wasn't showing on production after deploying my branch (assaydepot/phenovista-digital-storefront#38) to production was because the deploy changes needed to be in main to take effect. however, after merging the above to main and deploying again, the GTM ID still doesn't show up. I now believe the issue is related to the `NEXT_PUBLIC` prefix. Added it to the GTM ID so that the client should be able to pick up the variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
update charts for gtm to work in deployment
since
GOOGLE_TAG_MANAGER_IDis being referenced through an environment variable, it needed to be added as a deployment variable as well. we only need this value accessible in production, so I was able to remove it from the local env. the value should return as "undefined" and "" in the local and staging environments, respectively.related: #37
Expected Behavior After Changes
Notes
I deployed this branch to main, but the gtm id still wasn't picked up. I'm thinking that the deploy updates need to actually be in
mainto be picked up.