Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

36 gtm for the last time #39

Merged
merged 1 commit into from
Jan 24, 2024
Merged

36 gtm for the last time #39

merged 1 commit into from
Jan 24, 2024

Conversation

alishaevn
Copy link
Member

@alishaevn alishaevn commented Jan 24, 2024

Story

I thought that the reason the GTM ID wasn't showing on production after deploying my branch to production was because the deploy changes needed to be in main to take effect. however, after merging the above to main and deploying again, the GTM ID still doesn't show up.

I now believe the issue is related to the NEXT_PUBLIC prefix. Added it to the GTM ID so that the client should be able to pick up the variable.

Expected Behavior After Changes

  • the GTM ID is finally visible on prod

Screenshots / Video

the id is visible in the blue section!

image

I thought that the reason the GTM ID wasn't showing on production after
deploying my branch (#38)
to production was because the deploy changes needed to be in main to take
effect. however, after merging the above to main and deploying again, the
GTM ID still doesn't show up.

I now believe the issue is related to the `NEXT_PUBLIC` prefix. Added it
to the GTM ID so that the client should be able to pick up the variable.
Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
phenovista ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 7:29pm

@alishaevn alishaevn linked an issue Jan 24, 2024 that may be closed by this pull request
1 task
@alishaevn alishaevn merged commit b553593 into main Jan 24, 2024
7 of 8 checks passed
@alishaevn alishaevn deleted the 36-gtm-for-the-last-time branch January 24, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google tag manager
2 participants