36 google tag manager #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I installed "@next/third-parties" according to [next js docs](https://nextjs.org/docs/pages/building-your-application/optimizing/third-party-libraries#google-tag-manager). the [package docs](https://github.com/vercel/next.js/blob/a7a403f4982c4ce8dc3988bf96de4238362a704f/packages/third-parties/src/google/gtm.tsx) show that it returns the necessary script tags. I was also able to see the tag in local dev, before I hid the gtmId behind an environment based conditional. (so that we only track on production) ref: #36
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
1 task
summer-cook
approved these changes
Jan 23, 2024
alishaevn
added a commit
that referenced
this pull request
Jan 24, 2024
since `GOOGLE_TAG_MANAGER_ID` was added as an environment variable, it needs to be listed with the other env variables in the charts and ops files. otherwise, the variable returns "undefined" in staging/production. related: #37
alishaevn
added a commit
that referenced
this pull request
Jan 24, 2024
since `GOOGLE_TAG_MANAGER_ID` is being referenced through an environment variable, it needed to be added as a deployment variable as well. we only need this value accessible in production, so I was able to remove it from the local env. the value should return as "undefined" and "" in the local and staging environments, respectively. related: #37
Merged
alishaevn
added a commit
to assaydepot/webstore
that referenced
this pull request
Jan 24, 2024
since `GOOGLE_TAG_MANAGER_ID` is being referenced through an environment variable, it needed to be added as a deployment variable as well. we only need this value accessible in production, so I was able to remove it from the local env. the value should return as "undefined" and "" in the local and staging environments, respectively. related: assaydepot/phenovista-digital-storefront#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
I installed "@next/third-parties" according to next js docs. the package docs show that it returns the necessary script tags. I was also able to see the tag in local dev, before I hid the gtmId behind an environment based conditional. (so that we only track on production)
Expected Behavior After Changes
Screenshots / Video
inspecting the page, we see that the script for google tag manager has been added. we also see that the
gtmIdvalue is blank, as it should be because this is local dev and not production.