Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ENV support #7

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Added ENV support #7

wants to merge 3 commits into from

Conversation

ralphte
Copy link

@ralphte ralphte commented Nov 6, 2021

Added support for environment variables. We need this for DNS auth.

@mleutenegger
Copy link
Member

Hi there,
first off, thanks for the PR!

I'm not entirely sure wether the second commit (169f3d3) was actually meant to go to this PR, as it seems to completely alter the Repo 😬

f475849 looks OK, I will review it when the Question above is resolved.

@ralphte
Copy link
Author

ralphte commented Nov 11, 2021

Sorry had a little git SNAFU. Reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralphte @mleutenegger