Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove /test command comment #14164

Merged
merged 2 commits into from
Feb 11, 2025
Merged

fix: remove /test command comment #14164

merged 2 commits into from
Feb 11, 2025

Conversation

Joibel
Copy link
Member

@Joibel Joibel commented Feb 10, 2025

Partial revert of #14151

Fixes /test command not showing in github checks and extra CI jobs running

Motivation

The /test command isn't as important as the rest of #14151, so just remove it for now as it doesn't work as well as hoped and has issues

Modifications

Remove issue_comment from the actions and associated if

Verification

Untested as github action code, and changes are a revert.

Documentation

Reverted documentation for releasing process to use the old manual push, and removed docs on /test

Partial revert of #14151

Signed-off-by: Alan Clucas <[email protected]>
@Joibel Joibel marked this pull request as ready for review February 10, 2025 09:51
@Joibel Joibel added area/build Build or GithubAction/CI issues area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix prioritized-review For members of the Sustainability Effort labels Feb 10, 2025
@Joibel
Copy link
Member Author

Joibel commented Feb 10, 2025

/cherry-pick release-3.5

@Joibel
Copy link
Member Author

Joibel commented Feb 10, 2025

/cherry-pick release-3.6

Copy link
Member

@isubasinghe isubasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunate but fair enough.

@Joibel Joibel merged commit 6c34316 into main Feb 11, 2025
31 checks passed
@Joibel Joibel deleted the revert-test-comment branch February 11, 2025 08:21
Copy link

Cherry-pick failed with Merge error 6c34316fefe3cc1c0f2bc1bdd65e1bbaacddc822 into temp-cherry-pick-a30541-release-3.5

Copy link

Cherry-pick failed with Merge error 6c34316fefe3cc1c0f2bc1bdd65e1bbaacddc822 into temp-cherry-pick-a30541-release-3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix prioritized-review For members of the Sustainability Effort
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants