feat: enable cherry-pick bot #14151
Merged
feat: enable cherry-pick bot #14151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Clucas <[email protected]>
Joibel
changed the title
/test comment
terrytangyuan
approved these changes
Feb 6, 2025
sarabala1979
approved these changes
Feb 6, 2025
|
/cherry-pick release-3.6 |
|
Cherry-pick failed with |
|
/cherry-pick release-3.5 |
|
Cherry-pick failed with |
Joibel
added a commit
to pipekit/argo-workflows
that referenced
this pull request
Feb 6, 2025
(cherry picked from commit e4f51c2)
Joibel
added a commit
that referenced
this pull request
Feb 6, 2025
(cherry picked from commit e4f51c2) Signed-off-by: Alan Clucas <[email protected]>
|
The |
|
@Joibel Why does my normal comments also trigger CI: https://github.com/argoproj/argo-workflows/actions/runs/13213864653？ |
|
I forgot there were two entrypoints to the CI workflow, and only added an I'll work out whether to remove |
Joibel
added a commit
that referenced
this pull request
Feb 10, 2025
Partial revert of #14151 Signed-off-by: Alan Clucas <[email protected]>
|
#14164 is a partial revert to fix these two issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12592
Motivation
Maintaining released versions of argo-workflows is not automated. This will help by allowing the backporting of commits as they are merged rather than by the release manager at the time of release.
Each PR can be CI tested independently then, and only those that pass get merged.
Modifications
Enabled CI on release branch PRs.
Added a new /cherry-pick action, using the same cherry-pick-bot as argo-cd already use. I have already enabled that bot on this project, but it needs a configuration file as provided here.
Verification
This mostly needs testing after merging.
Documentation
Added documentation for how to use
/cherry-pick, and for the other comment based command which already existed:/retest