feat: persist k8s client QPS/Burst values #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR addresses issue introduced by kubernetes/cli-runtime#23 |
chen-keinan
reviewed
Jan 7, 2024
examples/trivy.go
Outdated
Comment on lines
22
to
52
| func WithQPS(qps float32) k8s.ClusterOption { | ||
| return func(o *genericclioptions.ConfigFlags) { | ||
| o.WrapConfigFn = combineConfigFns(o.WrapConfigFn, func(c *rest.Config) *rest.Config { | ||
| c.QPS = qps | ||
| return c | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func WithBurst(burst int) k8s.ClusterOption { | ||
| return func(o *genericclioptions.ConfigFlags) { | ||
| o.WrapConfigFn = combineConfigFns(o.WrapConfigFn, func(c *rest.Config) *rest.Config { | ||
| c.Burst = burst | ||
| return c | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| // Helper function to combine multiple config functions | ||
| func combineConfigFns(existing, newFn func(*rest.Config) *rest.Config) func(*rest.Config) *rest.Config { | ||
| if existing == nil { | ||
| return newFn | ||
| } | ||
| return func(c *rest.Config) *rest.Config { | ||
| if modified := existing(c); modified != nil { | ||
| return newFn(modified) | ||
| } | ||
| return newFn(c) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
should these option function should be in k8s.go file?
There was a problem hiding this comment.
Yeah. I have moved them over to k8s.go file.
|
lgtm 🚀 |
chen-keinan
approved these changes
Jan 8, 2024
7 tasks
thapabishwa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intents to allow end users to use custom QPS/Burst value with
trivy-kuberneteslibrary with wrapper functionsOutput after QPS/Burst value set to 100/100 (after this PR)
Output with no overrides(before this PR)
@chen-keinan This PR fixes the issues we discussed in #262