feat: introduce WithQPS and WithBurst functions #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chen-keinan
reviewed
Dec 6, 2023
There was a problem hiding this comment.
@thapabishwa thank you for pointing it out. change lgtm 🚀 I have added couple of comments
Comment on lines
+183
to
+211
| fmt.Println("kubeconfig QPS:", kubeConfig.QPS) | ||
| fmt.Println("kubeconfig Burst:", kubeConfig.Burst) | ||
|
|
||
| // kubeConfig.QPS = 2000 | ||
| // kubeConfig.Burst = 2000 | ||
| /* uncomment the above lines to manually set QPS and Burst | ||
| after manually setting QPS and Burst, your response time will be much faster | ||
|
|
||
| example output with WithQPS(2000) and WithBurst(2000) functions: | ||
| Setting burst to 2000 | ||
| Setting QPS to 2000 | ||
| kubeconfig QPS: 0 (qps and burst are reset to 0) | ||
| kubeconfig Burst: 0 | ||
| Current namespace: default | ||
| Scanning cluster | ||
| Time taken: 2.057551041s | ||
| Name: coredns, Kind: Deployment, Namespace: kube-system, Images: [registry.k8s.io/coredns/coredns:v1.10.1] | ||
|
|
||
| example output after manually setting QPS and Burst: | ||
| Setting burst to 2000 | ||
| Setting QPS to 2000 | ||
| kubeconfig QPS: 2000 (manually set values) | ||
| kubeconfig Burst: 2000 (manually set values) | ||
| Current namespace: default | ||
| Scanning cluster | ||
| Time taken: 89.546083ms | ||
| Name: coredns, Kind: Deployment, Namespace: kube-system, Images: [registry.k8s.io/coredns/coredns:v1.10.1] | ||
| */ | ||
|
|
There was a problem hiding this comment.
thanks for example , I think this comment can be removed
| @@ -139,6 +139,21 @@ func WithKubeConfig(kubeConfig string) ClusterOption { | |||
| } | |||
| } | |||
|
|
|||
| func WithQPS(qps float32) ClusterOption { | |||
| return func(o *genericclioptions.ConfigFlags) { | |||
| fmt.Println("Setting QPS to", qps) | |||
There was a problem hiding this comment.
I think the fmt.Println can be removed
| // WithBurst sets the burst limit for the client | ||
| func WithBurst(burst int) ClusterOption { | ||
| return func(o *genericclioptions.ConfigFlags) { | ||
| fmt.Println("Setting burst to", burst) |
There was a problem hiding this comment.
I think the fmt.Println can be removed
thapabishwa
force-pushed
the
QPS-Burst-Bug
branch
from
d68c121 to
ec2224b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chen-keinan
Unfortunately I couldn't create an issue on this repo like we discussed.
As such, I have created this PR to reflect the changes that I made on my end to while I encountered the issue.
I believe that might help you to pin point the issue.