-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature gate permissioned signer #15622
Merged
Merged
+218
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 35m total CI duration on this PR
|
This was referenced Dec 17, 2024
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. |
22 tasks
runtian-zhou
requested review from
davidiw,
movekevin and
wrwg
as code owners
December 17, 2024 15:20
runtian-zhou
force-pushed
the
10-09-create_benchmark
branch
from
December 18, 2024 07:37
60ce91a
to
b99540a
Compare
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
December 18, 2024 07:37
6494f73
to
2bd4613
Compare
runtian-zhou
force-pushed
the
10-09-create_benchmark
branch
from
January 8, 2025 23:55
b99540a
to
9060d7b
Compare
runtian-zhou
requested review from
junkil-park,
alinush and
a team
as code owners
January 8, 2025 23:55
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
January 8, 2025 23:56
2bd4613
to
472be55
Compare
runtian-zhou
force-pushed
the
10-09-create_benchmark
branch
from
January 9, 2025 00:55
9060d7b
to
266f326
Compare
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
January 9, 2025 00:55
472be55
to
18a8c9a
Compare
runtian-zhou
force-pushed
the
10-09-create_benchmark
branch
from
January 9, 2025 03:44
266f326
to
dceaa7d
Compare
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
January 9, 2025 03:44
18a8c9a
to
015bf33
Compare
runtian-zhou
force-pushed
the
10-09-create_benchmark
branch
from
January 9, 2025 07:58
dceaa7d
to
bb73811
Compare
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
January 9, 2025 07:58
015bf33
to
f9ea87a
Compare
runtian-zhou
force-pushed
the
10-09-create_benchmark
branch
from
January 10, 2025 18:48
bb73811
to
f90a810
Compare
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
January 10, 2025 18:48
f9ea87a
to
8148ebc
Compare
runtian-zhou
force-pushed
the
10-09-create_benchmark
branch
from
January 15, 2025 17:55
5d7f12a
to
de618cd
Compare
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
January 15, 2025 17:56
f8c3ecb
to
d3219e1
Compare
runtian-zhou
force-pushed
the
10-09-create_benchmark
branch
from
January 15, 2025 18:25
de618cd
to
aa7cdfe
Compare
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
January 15, 2025 18:25
d3219e1
to
4be61e5
Compare
igor-aptos
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relooking - this is not gated properly:
- nobody should be able to make a native call before feature is enabled. so is_permissioned_signer needs to be gated, and also all places that call permission_address - though those seem to be conditional to is_permissioned_signer as far as I can see
- we should also gate create_permissioned_handle and create_storable_permissioned_handle
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
2 times, most recently
from
January 15, 2025 18:53
819f0a5
to
c540d90
Compare
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
January 15, 2025 19:16
c540d90
to
54d5d99
Compare
igor-aptos
approved these changes
Jan 15, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
runtian-zhou
added a commit
that referenced
this pull request
Jan 15, 2025
runtian-zhou
added a commit
that referenced
this pull request
Jan 15, 2025
runtian-zhou
added a commit
that referenced
this pull request
Jan 16, 2025
runtian-zhou
added a commit
that referenced
this pull request
Jan 16, 2025
runtian-zhou
added a commit
that referenced
this pull request
Jan 16, 2025
runtian-zhou
added a commit
that referenced
this pull request
Jan 16, 2025
* Feature gate permissioned signer (#15622) * Add permissions for framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for permissioned signer functionality in the Aptos framework by introducing a new feature flag
PERMISSIONED_SIGNER
. This change enables controlled access to signer capabilities through permission checks. The implementation includes feature flag assertions in the permissioned signer module to ensure the feature is enabled before use.How Has This Been Tested?
The feature flag implementation follows established patterns used for other feature flags in the system. Testing is enforced through the existing feature flag testing infrastructure.
Key Areas to Review
permissioned_signer.move
signer_from_permissioned_handle
andsigner_from_storable_permissioned_handle
features.move
Type of Change
Which Components or Systems Does This Change Impact?
Checklist