[feature] Add permissioned signer functionality #14521

runtian-zhou · 2024-09-04T08:55:49Z

Description

Implement rust extension for the permissioned signer, including the new ser/de logic.

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

This will be tested with future PRs. Also a replay-verify is executed to make sure this feature is not breaking.

Key Areas to Review

We still need to keep the old serialization logic in the bcs module because it can otherwise cause on chain divergence.

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-09-04T08:55:53Z

⏱️ 3h 32m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
rust-move-unit-coverage	19m	🟩
rust-move-unit-coverage	18m	🟩
rust-cargo-deny	15m	🟩 🟩 🟩 🟩 🟩 (+3 more)
rust-move-unit-coverage	14m	🟩
general-lints	14m	🟩 🟩 🟩 🟩 🟩 (+3 more)
rust-move-unit-coverage	14m	🟩
rust-move-tests	13m	🟩
rust-move-unit-coverage	11m	🟩
rust-move-tests	9m	🟥
rust-move-tests	9m	🟥
rust-move-tests	9m	🟥
rust-move-tests	9m	🟥
rust-move-tests	9m	🟥
rust-move-tests	8m	🟥
check-dynamic-deps	8m	🟩 🟩 🟩 🟩 🟩 (+3 more)

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

runtian-zhou · 2024-09-04T08:55:57Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2024-09-04T09:02:43Z

Codecov Report

Attention: Patch coverage is 85.80247% with 23 lines in your changes missing coverage. Please review.

Project coverage is 60.1%. Comparing base (e7391d6) to head (7c5a356).

Files with missing lines	Patch %	Lines
...party/move/move-vm/types/src/values/values_impl.rs	75.0%	13 Missing ⚠️
...-move/framework/src/natives/permissioned_signer.rs	94.2%	3 Missing ⚠️
...rd_party/move/move-compiler-v2/src/plan_builder.rs	50.0%	3 Missing ⚠️
third_party/move/move-vm/types/src/value_serde.rs	40.0%	3 Missing ⚠️
third_party/move/move-core/types/src/value.rs	92.8%	1 Missing ⚠️

Additional details and impacted files

@@                            Coverage Diff                             @@
##           08-29-create_permissioned_signer_example   #14521    +/-   ##
==========================================================================
  Coverage                                      60.1%    60.1%            
==========================================================================
  Files                                           856      857     +1     
  Lines                                        211026   210762   -264     
==========================================================================
- Hits                                         126865   126723   -142     
+ Misses                                        84161    84039   -122

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

igor-aptos · 2025-01-08T18:48:59Z

aptos-move/aptos-gas-schedule/src/gas_schedule/aptos_framework.rs

@@ -6,7 +6,7 @@
 use crate::{
    gas_feature_versions::{RELEASE_V1_14, RELEASE_V1_8, RELEASE_V1_9_SKIPPED},
    gas_schedule::NativeGasParameters,
-    ver::gas_feature_versions::{RELEASE_V1_12, RELEASE_V1_13, RELEASE_V1_23},
+    ver::gas_feature_versions::{RELEASE_V1_12, RELEASE_V1_13, RELEASE_V1_23, RELEASE_V1_25},


1_26 now :)

igor-aptos · 2025-01-08T20:50:22Z

aptos-move/framework/src/natives/permissioned_signer.rs

+    debug_assert!(arguments.len() == 2);
+
+    let permission_addr = safely_pop_arg!(arguments, AccountAddress);
+    let master_addr = safely_pop_arg!(arguments, AccountAddress);


don't we need to verify that the handle exists, either here, or in the move code?

It was indeed validated on the move side.

third_party/move/move-core/types/src/value.rs

igor-aptos · 2025-01-09T00:02:48Z

third_party/move/move-core/types/src/value.rs

+                let (_, fields) = MoveStructLayout::signer()
+                    .deserialize(deserializer)?
+                    .into_optional_variant_and_fields();
+                Ok(MoveValue::Signer(match fields[0] {
+                    MoveValue::Address(addr) => addr,
+                    _ => return Err(D::Error::custom("signer deserialization error")),
+                }))


this deserves a comment on what it does here and why

igor-aptos · 2025-01-09T00:03:00Z

third_party/move/move-core/types/src/value.rs

@@ -691,7 +704,9 @@ impl serde::Serialize for MoveValue {
            MoveValue::U128(i) => serializer.serialize_u128(*i),
            MoveValue::U256(i) => i.serialize(serializer),
            MoveValue::Address(a) => a.serialize(serializer),
-            MoveValue::Signer(a) => a.serialize(serializer),
+            MoveValue::Signer(a) => {
+                MoveStruct::new_variant(0, vec![MoveValue::Address(*a)]).serialize(serializer)


this deserves a comment on what it does here and why

igor-aptos · 2025-01-09T00:06:25Z

third_party/move/move-core/types/src/value.rs

@@ -691,7 +704,9 @@ impl serde::Serialize for MoveValue {
            MoveValue::U128(i) => serializer.serialize_u128(*i),
            MoveValue::U256(i) => i.serialize(serializer),
            MoveValue::Address(a) => a.serialize(serializer),
-            MoveValue::Signer(a) => a.serialize(serializer),
+            MoveValue::Signer(a) => {


MoveValue::Signer doesn't change?

third_party/move/move-vm/types/src/values/values_impl.rs

aptos-move/e2e-move-tests/src/lib.rs

.github/actions/rust-targeted-unit-tests/action.yaml

aptos-move/e2e-move-tests/src/lib.rs

aptos-move/framework/src/aptos.rs

aptos-move/framework/tests/gate_v2_features.rs

third_party/move/scripts/move_pr.sh

runtian-zhou mentioned this pull request Sep 4, 2024

create permissioned signer example #14469

Open

21 tasks

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 456f5f4 to 55771fc Compare September 4, 2024 20:29

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 31c9b2c to 6d309ff Compare September 4, 2024 20:30

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 55771fc to 070a951 Compare September 5, 2024 00:41

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6d309ff to 703921b Compare September 5, 2024 00:41

runtian-zhou mentioned this pull request Sep 5, 2024

Add permission check to account #14535

Open

10 tasks

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 070a951 to b832d3d Compare September 9, 2024 07:08

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 703921b to 48991ff Compare September 9, 2024 07:08

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from b832d3d to 6ddb481 Compare September 9, 2024 07:46

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 48991ff to 906c7c7 Compare September 9, 2024 07:47

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 6ddb481 to 8b92b98 Compare September 9, 2024 17:09

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 906c7c7 to 350db4c Compare September 9, 2024 17:09

runtian-zhou mentioned this pull request Sep 9, 2024

add permissions for fungible assets operation #14567

Open

21 tasks

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 8b92b98 to fa646c8 Compare September 10, 2024 17:24

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 350db4c to dad258f Compare September 10, 2024 17:25

runtian-zhou mentioned this pull request Sep 10, 2024

add perimission checks to object #14582

Open

10 tasks

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from fa646c8 to c3aba3a Compare September 10, 2024 17:29

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from dad258f to 6b4da66 Compare September 10, 2024 17:29

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from c3aba3a to 50b556b Compare September 12, 2024 01:49

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6b4da66 to b1fd015 Compare September 12, 2024 01:50

runtian-zhou mentioned this pull request Sep 12, 2024

permission for framework #14605

Open

21 tasks

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 50b556b to 8cd68d5 Compare September 17, 2024 05:08

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from b1fd015 to 6592c01 Compare September 17, 2024 05:08

lightmark changed the title ~~Implement rust logics for permissioned signer~~ [feature] Add permissioned signer functionality Sep 17, 2024

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch 3 times, most recently from 1835d3d to 42decc7 Compare September 18, 2024 17:52

runtian-zhou requested review from davidiw, movekevin, wrwg and a team as code owners December 14, 2024 15:27

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from bcf98d8 to 93706d9 Compare December 14, 2024 17:59

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 1302971 to 4505dc2 Compare December 14, 2024 17:59

runtian-zhou mentioned this pull request Dec 16, 2024

Add another flavor of permission api #15609

Draft

22 tasks

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 93706d9 to cad586d Compare December 16, 2024 16:35

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 4505dc2 to 2dfa163 Compare December 16, 2024 16:35

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from cad586d to 59309c6 Compare December 17, 2024 02:26

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 2dfa163 to 7b93a7d Compare December 17, 2024 02:27

runtian-zhou mentioned this pull request Dec 17, 2024

Feature gate permissioned signer #15622

Open

8 tasks

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 59309c6 to dec8882 Compare January 8, 2025 23:54

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 7b93a7d to 4c1f016 Compare January 8, 2025 23:54

igor-aptos reviewed Jan 9, 2025

View reviewed changes

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from dec8882 to cadf003 Compare January 9, 2025 00:54

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch 2 times, most recently from 558c74e to beacad5 Compare January 9, 2025 03:43

wrwg reviewed Jan 9, 2025

View reviewed changes

aptos-move/e2e-move-tests/src/lib.rs Outdated Show resolved Hide resolved

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from beacad5 to 5a4e0b4 Compare January 9, 2025 07:57

rahxephon89 reviewed Jan 9, 2025

View reviewed changes

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from cadf003 to 1fd9d08 Compare January 10, 2025 18:47

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 5a4e0b4 to 3bc592c Compare January 10, 2025 18:47

runtian-zhou mentioned this pull request Jan 10, 2025

Create object with permissioned signer #15707

Draft

22 tasks

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 1fd9d08 to 600433c Compare January 10, 2025 22:50

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 3bc592c to efd4b1b Compare January 10, 2025 22:50

runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 600433c to 2109874 Compare January 10, 2025 22:58

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from efd4b1b to b7dadf2 Compare January 10, 2025 22:58

implement rust logics and specs

a96ae99

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from b7dadf2 to a96ae99 Compare January 10, 2025 23:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature] Add permissioned signer functionality #14521

[feature] Add permissioned signer functionality #14521

runtian-zhou commented Sep 4, 2024 •

edited

Loading

trunk-io bot commented Sep 4, 2024 •

edited

Loading

runtian-zhou commented Sep 4, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024 •

edited

Loading

igor-aptos Jan 8, 2025

igor-aptos Jan 8, 2025

runtian-zhou Jan 11, 2025

igor-aptos Jan 9, 2025

igor-aptos Jan 9, 2025

igor-aptos Jan 9, 2025

[feature] Add permissioned signer functionality #14521

Are you sure you want to change the base?

[feature] Add permissioned signer functionality #14521

Conversation

runtian-zhou commented Sep 4, 2024 • edited Loading

Description

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Key Areas to Review

Checklist

trunk-io bot commented Sep 4, 2024 • edited Loading

runtian-zhou commented Sep 4, 2024 • edited Loading

codecov bot commented Sep 4, 2024 • edited Loading

Codecov Report

igor-aptos Jan 8, 2025

Choose a reason for hiding this comment

igor-aptos Jan 8, 2025

Choose a reason for hiding this comment

runtian-zhou Jan 11, 2025

Choose a reason for hiding this comment

igor-aptos Jan 9, 2025

Choose a reason for hiding this comment

igor-aptos Jan 9, 2025

Choose a reason for hiding this comment

igor-aptos Jan 9, 2025

Choose a reason for hiding this comment

runtian-zhou commented Sep 4, 2024 •

edited

Loading

trunk-io bot commented Sep 4, 2024 •

edited

Loading

runtian-zhou commented Sep 4, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024 •

edited

Loading