[framework][object] Introduce ability to recreate objects after deletion #15576
+472
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 53m total CI duration on this PR
|
This was referenced Dec 12, 2024
This was referenced Dec 12, 2024
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
173
to
184
| /// Used to (re)create object at a given address | ||
| enum CreateAtAddressRef has drop, store { | ||
| RecreateV1 { | ||
| object: address, | ||
| owner: address, | ||
| guid_creation_num: u64, | ||
| untransferable: bool, | ||
| allow_ungated_transfer: bool, | ||
| transfer_events: event::EventHandle<TransferEvent> | ||
| }, | ||
| } |
There was a problem hiding this comment.
Replace enum CreateAtAddressRef with a struct containing the same fields to be compatible with Move v1
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
Comment on lines
173
to
184
| /// Used to (re)create object at a given address | ||
| enum CreateAtAddressRef has drop, store { | ||
| RecreateV1 { | ||
| object: address, | ||
| owner: address, | ||
| guid_creation_num: u64, | ||
| untransferable: bool, | ||
| allow_ungated_transfer: bool, | ||
| transfer_events: event::EventHandle<TransferEvent> | ||
| }, | ||
| } |
There was a problem hiding this comment.
Replace enum CreateAtAddressRef with a struct since Move 2 enum features are not yet enabled. Suggested replacement:
struct CreateAtAddressRef has drop, store {
object: address,
owner: address,
guid_creation_num: u64,
untransferable: bool,
allow_ungated_transfer: bool,
transfer_events: event::EventHandle
}
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
8 tasks
igor-aptos
force-pushed
the
igor/add_to_property_map
branch
from
9993745 to
b9bd71c
Compare
This was referenced Dec 12, 2024
igor-aptos
force-pushed
the
igor/object_delete_and_recreate
branch
from
eb16207 to
7092a12
Compare
22 tasks
Comment on lines
55
to
56
| /// Cannot delete_and_can_recreate with TombStone present. | ||
| const ETOMBSTONE_CANNOT_BE_PRESENT: u64 = 10; |
There was a problem hiding this comment.
The error code 10 is already used by EBURN_NOT_ALLOWED, so ETOMBSTONE_CANNOT_BE_PRESENT should use a different value (such as 11) to avoid ambiguous error handling. Having two different error conditions share the same code could make debugging more difficult and impact error reporting accuracy.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
igor-aptos
force-pushed
the
igor/add_to_property_map
branch
from
b9bd71c to
80291e3
Compare
igor-aptos
force-pushed
the
igor/object_delete_and_recreate
branch
from
7092a12 to
5cbb160
Compare
igor-aptos
force-pushed
the
igor/add_to_property_map
branch
from
80291e3 to
1094f18
Compare
igor-aptos
force-pushed
the
igor/object_delete_and_recreate
branch
from
5cbb160 to
e5f2580
Compare
igor-aptos
force-pushed
the
igor/add_to_property_map
branch
from
1094f18 to
4ce5c7c
Compare
igor-aptos
force-pushed
the
igor/object_delete_and_recreate
branch
from
e5f2580 to
57414cf
Compare
igor-aptos
force-pushed
the
igor/add_to_property_map
branch
from
4ce5c7c to
38d0b84
Compare
22 tasks
igor-aptos
force-pushed
the
igor/object_delete_and_recreate
branch
from
57414cf to
700d668
Compare
igor-aptos
force-pushed
the
igor/add_to_property_map
branch
from
38d0b84 to
979fae3
Compare
igor-aptos
force-pushed
the
igor/object_delete_and_recreate
branch
from
700d668 to
b8a9b02
Compare
igor-aptos
force-pushed
the
igor/add_to_property_map
branch
from
979fae3 to
e86528e
Compare
igor-aptos
force-pushed
the
igor/object_delete_and_recreate
branch
from
b8a9b02 to
e0c474e
Compare
igor-aptos
force-pushed
the
igor/add_to_property_map
branch
from
e86528e to
9836448
Compare
igor-aptos
force-pushed
the
igor/object_delete_and_recreate
branch
from
e0c474e to
95d8c20
Compare
igor-aptos
force-pushed
the
igor/add_to_property_map
branch
from
9836448 to
2817048
Compare
igor-aptos
force-pushed
the
igor/object_delete_and_recreate
branch
from
95d8c20 to
627e416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist