Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ungate native memory operations #15532

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

igor-aptos
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 6, 2024

⏱️ 51m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 23m 🟩
rust-move-tests 13m 🟩
rust-move-tests 7m 🟥
rust-cargo-deny 4m 🟩🟩
check-dynamic-deps 2m 🟩🟩
general-lints 56s 🟩🟩
semgrep/ci 47s 🟩🟩
file_change_determinator 25s 🟩🟩
permission-check 7s 🟩🟩
permission-check 7s 🟩🟩
check-branch-prefix 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

igor-aptos commented Dec 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@igor-aptos igor-aptos force-pushed the igor/ungate_native_memory_operations branch from fa59933 to d5b3656 Compare December 12, 2024 18:24
@igor-aptos igor-aptos force-pushed the igor/vector_replace_speedup branch from dc5accd to 4bc4bab Compare December 16, 2024 22:22
@igor-aptos igor-aptos force-pushed the igor/ungate_native_memory_operations branch from d5b3656 to 69d6f0b Compare December 16, 2024 22:22
Base automatically changed from igor/vector_replace_speedup to main December 19, 2024 05:09
@igor-aptos igor-aptos force-pushed the igor/ungate_native_memory_operations branch from 69d6f0b to 5eb9708 Compare January 7, 2025 20:57
@igor-aptos igor-aptos marked this pull request as ready for review January 9, 2025 18:00
@igor-aptos igor-aptos force-pushed the igor/ungate_native_memory_operations branch from 5eb9708 to e0891d9 Compare January 10, 2025 06:40
@igor-aptos igor-aptos added the CICD:run-execution-performance-test Run execution performance test label Jan 10, 2025
@igor-aptos igor-aptos force-pushed the igor/ungate_native_memory_operations branch from e0891d9 to 27784fc Compare January 10, 2025 07:30
@@ -50,9 +50,9 @@ pub fn create_prebuilt_packages_rs_file(
writeln!(
string_buffer,
"
use aptos_transaction_generator_lib::entry_point_trait::PreBuiltPackages;carg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a typo in the import statement - the trailing carg should be removed:

use aptos_transaction_generator_lib::entry_point_trait::PreBuiltPackages;

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@igor-aptos igor-aptos force-pushed the igor/ungate_native_memory_operations branch from 27784fc to 2aabb74 Compare January 10, 2025 08:34
@igor-aptos igor-aptos force-pushed the igor/ungate_native_memory_operations branch from 2aabb74 to afc5201 Compare January 10, 2025 16:28
@igor-aptos igor-aptos enabled auto-merge (squash) January 10, 2025 17:15

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on afc52013bbcbb0f0e546c68c645590b411308d0a

two traffics test: inner traffic : committed: 14665.80 txn/s, submitted: 14667.43 txn/s, expired: 1.63 txn/s, latency: 2702.53 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 4200 ms), latency samples: 5576240
two traffics test : committed: 99.96 txn/s, latency: 1379.35 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 1700 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.622, avg: 1.567", "ConsensusProposalToOrdered: max: 0.289, avg: 0.287", "ConsensusOrderedToCommit: max: 0.316, avg: 0.306", "ConsensusProposalToCommit: max: 0.603, avg: 0.593"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.53s no progress at version 331 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.58s no progress at version 2787344 (avg 0.58s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> afc52013bbcbb0f0e546c68c645590b411308d0a

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> afc52013bbcbb0f0e546c68c645590b411308d0a (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 17601.32 txn/s, latency: 1940.61 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 2400 ms), latency samples: 582900
2. Upgrading first Validator to new version: afc52013bbcbb0f0e546c68c645590b411308d0a
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7877.07 txn/s, latency: 3852.43 ms, (p50: 4500 ms, p70: 4600, p90: 4800 ms, p99: 5000 ms), latency samples: 149740
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7928.99 txn/s, latency: 4239.05 ms, (p50: 4600 ms, p70: 4700, p90: 5000 ms, p99: 5100 ms), latency samples: 264900
3. Upgrading rest of first batch to new version: afc52013bbcbb0f0e546c68c645590b411308d0a
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7247.68 txn/s, latency: 4131.32 ms, (p50: 4800 ms, p70: 5000, p90: 5100 ms, p99: 5300 ms), latency samples: 136220
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7251.68 txn/s, latency: 4580.29 ms, (p50: 4900 ms, p70: 5000, p90: 5100 ms, p99: 5200 ms), latency samples: 247440
4. upgrading second batch to new version: afc52013bbcbb0f0e546c68c645590b411308d0a
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12178.63 txn/s, latency: 2382.00 ms, (p50: 2700 ms, p70: 2800, p90: 3000 ms, p99: 3100 ms), latency samples: 218100
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 12326.98 txn/s, latency: 2652.49 ms, (p50: 2800 ms, p70: 3000, p90: 3000 ms, p99: 3300 ms), latency samples: 399980
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> afc52013bbcbb0f0e546c68c645590b411308d0a passed
Test Ok

@igor-aptos igor-aptos merged commit 86b696d into main Jan 10, 2025
91 checks passed
@igor-aptos igor-aptos deleted the igor/ungate_native_memory_operations branch January 10, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-execution-performance-test Run execution performance test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants