-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ungate native memory operations #15532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 51m total CI duration on this PR
|
This was referenced Dec 6, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
22 tasks
igor-aptos
force-pushed
the
igor/ungate_native_memory_operations
branch
from
December 12, 2024 18:24
fa59933
to
d5b3656
Compare
This was referenced Dec 12, 2024
igor-aptos
force-pushed
the
igor/vector_replace_speedup
branch
from
December 16, 2024 22:22
dc5accd
to
4bc4bab
Compare
igor-aptos
force-pushed
the
igor/ungate_native_memory_operations
branch
from
December 16, 2024 22:22
d5b3656
to
69d6f0b
Compare
igor-aptos
force-pushed
the
igor/ungate_native_memory_operations
branch
from
January 7, 2025 20:57
69d6f0b
to
5eb9708
Compare
22 tasks
msmouse
approved these changes
Jan 9, 2025
wrwg
approved these changes
Jan 10, 2025
igor-aptos
force-pushed
the
igor/ungate_native_memory_operations
branch
from
January 10, 2025 06:40
5eb9708
to
e0891d9
Compare
igor-aptos
added
the
CICD:run-execution-performance-test
Run execution performance test
label
Jan 10, 2025
igor-aptos
force-pushed
the
igor/ungate_native_memory_operations
branch
from
January 10, 2025 07:30
e0891d9
to
27784fc
Compare
@@ -50,9 +50,9 @@ pub fn create_prebuilt_packages_rs_file( | |||
writeln!( | |||
string_buffer, | |||
" | |||
use aptos_transaction_generator_lib::entry_point_trait::PreBuiltPackages;carg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a typo in the import statement - the trailing carg
should be removed:
use aptos_transaction_generator_lib::entry_point_trait::PreBuiltPackages;
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
igor-aptos
force-pushed
the
igor/ungate_native_memory_operations
branch
from
January 10, 2025 08:34
27784fc
to
2aabb74
Compare
igor-aptos
force-pushed
the
igor/ungate_native_memory_operations
branch
from
January 10, 2025 16:28
2aabb74
to
afc5201
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist