Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: implement release process in odev #5592

Merged
merged 14 commits into from
Feb 2, 2025
Merged

build: implement release process in odev #5592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c0facd7
build: implement release process in odev
tisonkun Feb 1, 2025
63b2ad9
remove unused version field
tisonkun Feb 1, 2025
bc9300e
impl update_package_version
tisonkun Feb 1, 2025
676c387
bridge packages
tisonkun Feb 1, 2025
cafb565
handle maven and node
tisonkun Feb 1, 2025
da247e6
update with regexp
tisonkun Feb 1, 2025
b8770d6
for nodejs
tisonkun Feb 1, 2025
d7a16d4
archive
tisonkun Feb 1, 2025
228d2f8
sign
tisonkun Feb 1, 2025
b072518
fixup
tisonkun Feb 1, 2025
d2ecc4d
update docs
tisonkun Feb 1, 2025
54362ff
license header
tisonkun Feb 1, 2025
411231d
lua is unreleased now
tisonkun Feb 1, 2025
a7c45b4
fixup
tisonkun Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/ISSUE_TEMPLATE/3-new-release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ This issue is used to track tasks of the opendal ${opendal_version} release.

### Build Release

#### Release List

<!-- Generate release list by `./scripts/version.py`, please adapt with the actual needs. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we can have something like:

/// Generate a release plan in text at `target/release.txt` and print to console.
just release plan

/// Dev can edit the release plan by hand on need like bump to 0.y+1 instead of 0.0.z+1

/// Execuate the generated plan.
just release run

The release plan can also be pasted in to PR and discussion to make the review easier.

The current way works either, maybe we can merge and move on first.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd considering an interactive experience like cargo-release, that prompt package versions one by one and ask the release manager to input the correct version. Then commit the updates as well as generate a release list.

Perhaps pick up in the next month.


#### GitHub Side

- [ ] Bump version in project
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Check license headers
uses: korandoru/hawkeye@v5
uses: korandoru/hawkeye@v6

# Add python format check later.
code-format:
Expand Down
1 change: 0 additions & 1 deletion bindings/c/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ homepage = "https://opendal.apache.org/"
license = "Apache-2.0"
repository = "https://github.com/apache/opendal"
rust-version = "1.75"
version = "0.45.3"

[lib]
crate-type = ["cdylib", "staticlib"]
Expand Down
1 change: 0 additions & 1 deletion bindings/cpp/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ homepage = "https://opendal.apache.org/"
license = "Apache-2.0"
repository = "https://github.com/apache/opendal"
rust-version = "1.75"
version = "0.45.15"

[lib]
crate-type = ["staticlib"]
Expand Down
1 change: 0 additions & 1 deletion bindings/dotnet/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
[package]
name = "opendal-dotnet"
publish = false
version = "0.1.13"

authors = ["Apache OpenDAL <[email protected]>"]
edition = "2021"
Expand Down
1 change: 0 additions & 1 deletion bindings/haskell/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ homepage = "https://opendal.apache.org/"
license = "Apache-2.0"
repository = "https://github.com/apache/opendal"
rust-version = "1.75"
version = "0.44.15"

[lib]
crate-type = ["cdylib"]
Expand Down
2 changes: 1 addition & 1 deletion bindings/haskell/opendal.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cabal-version: 3.0
-- under the License.

name: opendal
version: 0.44.15.0
version: 0.1.0
license: Apache-2.0
synopsis: Apache OpenDAL™ Haskell Binding
description:
Expand Down
1 change: 0 additions & 1 deletion bindings/java/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ homepage = "https://opendal.apache.org/"
license = "Apache-2.0"
repository = "https://github.com/apache/opendal"
rust-version = "1.75"
version = "0.47.7"

[lib]
crate-type = ["cdylib"]
Expand Down
2 changes: 1 addition & 1 deletion bindings/java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

<groupId>org.apache.opendal</groupId>
<artifactId>opendal</artifactId>
<version>0.47.7</version>
<version>0.47.7</version> <!-- update version number -->

<name>Apache OpenDAL™</name>
<description>
Expand Down
1 change: 0 additions & 1 deletion bindings/lua/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
[package]
name = "opendal-lua"
publish = false
version = "0.1.13"

authors = ["Apache OpenDAL <[email protected]>"]
edition = "2021"
Expand Down
11 changes: 8 additions & 3 deletions bindings/lua/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,36 +19,41 @@ print("read: ", op:read("test.txt"))
```

## Lua version

You have to enable one of the features: lua54, lua53, lua52, lua51, luajit(52) or luau in `Cargo.toml`, according to the chosen Lua version. Default Lua version is 5.2.

## Build from source

1. Build OpenDAL LUA Interface
1. Build OpenDAL Lua Interface

```bash
$ cd bindings/lua
$ cargo build --package opendal-lua --release
```

2. Install opendal lua library
2. Install opendal Lua library

```bash
# copy to lua share library directory
# default lua5.2 share library directory is /usr/lib/lua/5.2
$ cp ../../target/release/libopendal_lua.so /usr/lib/lua/5.2/opendal.so
```

## Install from luarocks
## Install from LuaRocks

```bash
$ luarocks make
```

## Usage

```bash
$ lua5.2 example/fs.lua
read: hello world
```

## Test

```bash
$ busted -o gtest test/opendal_test.lua
[==========] Running tests from scanned files.
Expand Down
2 changes: 1 addition & 1 deletion bindings/lua/opendal-0.1.13-1.rockspec → bindings/lua/opendal-0.1.0-1.rockspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
package = "opendal"
version = "0.1.13-1"
version = "0.1.0-1"

source = {
url = "git+https://github.com/apache/opendal/",
Expand Down
1 change: 0 additions & 1 deletion bindings/nodejs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ homepage = "https://opendal.apache.org/"
license = "Apache-2.0"
repository = "https://github.com/apache/opendal"
rust-version = "1.75"
version = "0.47.9"

[features]
default = [
Expand Down
1 change: 0 additions & 1 deletion bindings/ocaml/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
[package]
name = "opendal-ocaml"
publish = false
version = "0.0.0"

authors = ["Apache OpenDAL <[email protected]>"]
edition = "2021"
Expand Down
1 change: 0 additions & 1 deletion bindings/php/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
[package]
name = "opendal-php"
publish = false
version = "0.1.12"

authors = ["Apache OpenDAL <[email protected]>"]
edition = "2021"
Expand Down
1 change: 0 additions & 1 deletion bindings/ruby/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
[package]
name = "opendal-ruby"
publish = false
version = "0.1.13"

authors = ["Apache OpenDAL <[email protected]>"]
edition = "2021"
Expand Down
Loading
Loading