build: implement release process in odev #5592
Merged
+817
−230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
tisonkun
requested review from
PsiACE,
suyanhanx,
oowl,
silver-ymz,
xyjixyjixyji and
Xuanwo
as code owners
tisonkun
commented
Feb 1, 2025
dev/src/release/mod.rs
Outdated
| let files = output.lines().collect::<Vec<_>>(); | ||
| archive_and_checksum(&package, &files)?; | ||
|
|
||
| let prefix = format!("apache-opendal-{}-src", package.name.replace("/", "-")); |
There was a problem hiding this comment.
Need to add the version to prefix
tisonkun
commented
Feb 1, 2025
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Xuanwo
reviewed
Feb 2, 2025
| @@ -14,10 +14,6 @@ This issue is used to track tasks of the opendal ${opendal_version} release. | |||
|
|
|||
| ### Build Release | |||
|
|
|||
| #### Release List | |||
|
|
|||
| <!-- Generate release list by `./scripts/version.py`, please adapt with the actual needs. --> | |||
There was a problem hiding this comment.
I wish we can have something like:
/// Generate a release plan in text at `target/release.txt` and print to console.
just release plan
/// Dev can edit the release plan by hand on need like bump to 0.y+1 instead of 0.0.z+1
/// Execuate the generated plan.
just release run
The release plan can also be pasted in to PR and discussion to make the review easier.
The current way works either, maybe we can merge and move on first.
There was a problem hiding this comment.
I'd considering an interactive experience like cargo-release, that prompt package versions one by one and ask the release manager to input the correct version. Then commit the updates as well as generate a release list.
Perhaps pick up in the next month.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add:
just update-versionfor update all the release targets' version fieldjust releasefor generate all the release artifacts