samv7/spi: fix ifdelay setup in spi_setdelay call #15900
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifdelay description (delay between frames) matches the DLYBCT field (delay between consecutive transfers without removing chip select) much better compared to stopdelay (delay between last CLK and CS innactive). The option for stopdelay does not seem to be configurable in SAMv7 peripheral. Signed-off-by: Michal Lenc <[email protected]>
github-actions
bot
added
Arch: arm
|
@pkarashchenko Could you take a look? I think this makes much more sense, but I hope it won't break the behavior for someone using SPI... it shouldn't though, this call is not used that much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ifdelaydescription (delay between frames) matches the DLYBCT field (delay between consecutive transfers without removing chip select) much better compared tostopdelay(delay between last CLK and CS innactive). The option forstopdelaydoes not seem to be configurable in SAMv7 peripheral.Impact
Should be minimal, most of the drivers do not use
spi_setdelayat all and even if, this is configurable option disabled by default.Testing
Tested with ST7789 display, the delay is set up. The delay is put between the consecutive transfers, so the effect now matches the description.