Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror a wifi deadlock fix to espressif variants #15532

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Jan 14, 2025

Summary

mirror a wifi deadlock fix to espressif variants.

Impact

Testing

not tested.
i don't have hardware handy.

@github-actions github-actions bot added Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: xtensa Issues related to the Xtensa architecture Size: S The size of the change in this PR is small labels Jan 14, 2025
@yamt yamt mentioned this pull request Jan 14, 2025
1 task
@nuttxpr
Copy link

nuttxpr commented Jan 14, 2025

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements. It is missing critical information.

Here's why:

  • Insufficient Summary: While the summary mentions what is being changed (a wifi deadlock fix), it lacks crucial details like why the change is necessary (what was the original deadlock?), how the fix works, and any related issue references.
  • Missing Impact Assessment: The "Impact" section is entirely empty. This is a significant omission. At minimum, it needs to address the impact on hardware (since it mentions Espressif variants) and potentially compatibility.
  • Inadequate Testing: The author explicitly states the changes are not tested due to lack of hardware. This is unacceptable for a PR. Testing is crucial for verifying the fix works as intended and doesn't introduce new issues. The author needs to find a way to test the changes, possibly using simulation or borrowing hardware. Empty log sections are also unhelpful.

In short, this PR needs substantial revision before it can be considered. The author needs to provide the missing information and, most importantly, perform thorough testing.

@xiaoxiang781216 xiaoxiang781216 linked an issue Jan 14, 2025 that may be closed by this pull request
1 task
@xiaoxiang781216 xiaoxiang781216 merged commit b88aba5 into apache:master Jan 14, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: xtensa Issues related to the Xtensa architecture Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] esp32s3 wifi deadlock
3 participants