[BUG] esp32s3 wifi deadlock

[yamt]

Description / Steps to reproduce the issue

net_lock() and esp_wifi_lock() are taken in an inconsistent order.
thus it can cause a deadlock.

wlan_ifdown net_lock();
  |
  v
esp_wifi_sta_stop esp_wifi_lock(true);

esp_evt_work_cb esp_wifi_lock(true);
  |
  v
esp32s3_wlan_sta_set_linkstatus(false)
  |
  v
netdev_carrier_off
  |
  v
devif_dev_event net_lock();

the most straightforward fix: make esp_evt_work_cb (and other functions taking esp_wifi_lock first if any) acquire net_lock() before esp_wifi_lock(). (note that net_lock() is a recursive lock.)

On which OS does this issue occur?

[OS: Mac]

What is the version of your OS?

macOS 15.2

NuttX Version

master

Issue Architecture

[Arch: xtensa]

Issue Area

[Area: Drivers]

Verification

• I have verified before submitting the report.

[fdcavalcanti]

Hi @yamt. Did you have issues on S3 using WiFi due to this?
What devkit did you use?

[yamt]

Hi @yamt. Did you have issues on S3 using WiFi due to this? What devkit did you use?

my colleague performed some tests, which connect/disconnect wifi repeatedly and found this issue. i think it was with a proprietary board with SMP enabled.

looking at the code, i don't think it's a board-specific issue. (thus reported here.)

[fdcavalcanti]

Interesting.
Feel free to submit this modification and I can test it on our internal CI.

[yamt]

Interesting. Feel free to submit this modification and I can test it on our internal CI.

see #15445

[yamt]

Interesting. Feel free to submit this modification and I can test it on our internal CI.

see #15445

see also #15532