arch/sim/src/nuttx-names.in: Add pipe2 #15226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Arch: simulator
1 task
|
the ci is expected to fail until apache/nuttx-apps#2893 is merged. |
This breaks the libuv build without CONFIG_PIPES as expected: ``` LD: nuttx /usr/bin/ld: nuttx.rel: in function `uv_pipe': /src/apps/system/libuv/libuv/src/unix/pipe.c:516: undefined reference to `NXpipe2' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:427: nuttx] Error 1 make: *** [tools/Unix.mk:551: nuttx] Error 2 ``` That is, this correctly exposes apache#14773 on linux.
rebased after the PR (and a few other related ones) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This breaks the libuv build without CONFIG_PIPES
as expected:
This exposes #14773 on linux.
Impact
Testing
build-tested on ubuntu, with and without apache/nuttx-apps#2893