-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system/libuv/Kconfig: select CONFIG_PIPES #2893
Conversation
libuv unconditionally uses pipe(). Fixes: apache/nuttx#14773
the corresponding defconfig updates: apache/nuttx#15230 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @yamt :-)
Build errors caused by CI problems, will restart :-) |
Still build errors :-( Does it come from this small change? o_O |
it seems like some kind of dependency loops, involving NET, PIPES, LUA_LUV_MODULE. i wonder why LUA_LUV_MODULE have that many "select". @xiaoxiang781216 do you prefer to make all of them to "depends on" as well? |
Yes. |
ok. i will submit the change later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build errors :-(
|
Summary
libuv unconditionally uses pipe().
Fixes: apache/nuttx#14773
Impact
Testing
build tested on ubuntu with apache/nuttx#15226
build tested on macOS