Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system/libuv/Kconfig: select CONFIG_PIPES #2893

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Dec 17, 2024

Summary

libuv unconditionally uses pipe().

Fixes: apache/nuttx#14773

Impact

Testing

build tested on ubuntu with apache/nuttx#15226
build tested on macOS

libuv unconditionally uses pipe().

Fixes: apache/nuttx#14773
@yamt
Copy link
Contributor Author

yamt commented Dec 17, 2024

the corresponding defconfig updates: apache/nuttx#15230

Copy link

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yamt :-)

@cederom
Copy link

cederom commented Dec 17, 2024

Build errors caused by CI problems, will restart :-)

@cederom
Copy link

cederom commented Dec 17, 2024

Still build errors :-( Does it come from this small change? o_O

@yamt
Copy link
Contributor Author

yamt commented Dec 18, 2024

it seems like some kind of dependency loops, involving NET, PIPES, LUA_LUV_MODULE.

i wonder why LUA_LUV_MODULE have that many "select". @xiaoxiang781216 do you prefer to make all of them to "depends on" as well?

@xiaoxiang781216
Copy link
Contributor

it seems like some kind of dependency loops, involving NET, PIPES, LUA_LUV_MODULE.

i wonder why LUA_LUV_MODULE have that many "select". @xiaoxiang781216 do you prefer to make all of them to "depends on" as well?

Yes.

@yamt
Copy link
Contributor Author

yamt commented Dec 18, 2024

it seems like some kind of dependency loops, involving NET, PIPES, LUA_LUV_MODULE.
i wonder why LUA_LUV_MODULE have that many "select". @xiaoxiang781216 do you prefer to make all of them to "depends on" as well?

Yes.

ok. i will submit the change later.

Copy link

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build errors :-(

@yamt
Copy link
Contributor Author

yamt commented Dec 18, 2024

it seems like some kind of dependency loops, involving NET, PIPES, LUA_LUV_MODULE.
i wonder why LUA_LUV_MODULE have that many "select". @xiaoxiang781216 do you prefer to make all of them to "depends on" as well?

Yes.

ok. i will submit the change later.

#2902
apache/nuttx#15264

@xiaoxiang781216 xiaoxiang781216 merged commit 3efbed1 into apache:master Dec 18, 2024
8 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] macOS CI: sim:lua doesn't link with pipe2()
5 participants