chore: unify the dependencies versions of the entire project #478
Conversation
github-actions
bot
added
client
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
=========================================
Coverage 62.48% 62.48%
Complexity 1868 1868
=========================================
Files 260 260
Lines 9432 9432
Branches 875 875
=========================================
Hits 5894 5894
Misses 3154 3154
Partials 384 384 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks & need check the CI problem |
conghuhu
force-pushed
the
pom
branch
3 times, most recently
from
c2d25b9 to
4cc540d
Compare
|
@imbajin PTAL |
| zookeeper-3.6.2.jar | ||
| zookeeper-jute-3.5.6.jar | ||
| zookeeper-jute-3.6.2.jar |
There was a problem hiding this comment.
These dependencies seems to have been duplicated, can we remove one version of them？
conghuhu
force-pushed
the
pom
branch
2 times, most recently
from
caa5b79 to
53270a0
Compare
|
check it: |
| <dependencyManagement> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <version>${junit.version}</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| </dependencies> | ||
| </dependencyManagement> | ||
|
|
| <dependency> | ||
| <groupId>com.fasterxml.jackson</groupId> | ||
| <artifactId>jackson-bom</artifactId> | ||
| <version>${jackson.version}</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> |
There was a problem hiding this comment.
why we need add jackson here? (seems client has included it)
There was a problem hiding this comment.
This is introduced to unify the dependencies related to jackson denpendencies of all submodules
There was a problem hiding this comment.
This is introduced to unify the dependencies related to jackson denpendencies of all submodules
OK, just ensure the need
| <guava.version>30.0-jre</guava.version> | ||
| <lz4.version>1.4.0</lz4.version> | ||
| <jcommand-version>1.72</jcommand-version> | ||
| <jackson.version>2.12.3</jackson.version> |
There was a problem hiding this comment.
and be careful, the jackson version may influence or have conflicts in some cases (like in spark/flink env, if we change the default version in loader, it's better to test it later, add a WARN comment for it
So I update guava to 32.0.1-jre
|
| netty-3.10.6.Final.jar | ||
| netty-all-4.1.68.Final.jar | ||
| netty-buffer-4.1.39.Final.jar | ||
| netty-buffer-4.1.50.Final.jar | ||
| netty-codec-4.1.39.Final.jar | ||
| netty-codec-4.1.50.Final.jar | ||
| netty-common-4.1.39.Final.jar | ||
| nimbus-jose-jwt-4.41.1.jar | ||
| netty-common-4.1.50.Final.jar | ||
| netty-handler-4.1.39.Final.jar | ||
| netty-handler-4.1.50.Final.jar | ||
| netty-resolver-4.1.39.Final.jar | ||
| netty-resolver-4.1.50.Final.jar | ||
| netty-transport-4.1.39.Final.jar | ||
| netty-transport-4.1.50.Final.jar | ||
| netty-transport-native-epoll-4.1.39.Final.jar | ||
| netty-transport-native-epoll-4.1.50.Final.jar | ||
| netty-transport-native-unix-common-4.1.39.Final.jar | ||
| netty-transport-native-unix-common-4.1.50.Final.jar |
There was a problem hiding this comment.
why a string of (& duplicate) netty jars appear?
There was a problem hiding this comment.
All of them form zookeeper in hugegraph-tools.
There was a problem hiding this comment.
seems a little strange, each netty dependency have 2 version now? ZK will not include 2 version?
There was a problem hiding this comment.
I have identified this issue and implemented version consistency by introducing netty-bom
There was a problem hiding this comment.
I have identified this issue and implemented version consistency by introducing
netty-bom
fine & no need to force-push commit so that we could review the latest change easily
the multi commit will be rebased together
fix: unify zk version chore: update guava to 32.0.0-jre
close #458