Add publishing datafusion-sqllogictest to release README.md #14233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
development-process
alamb
commented
Jan 22, 2025
| @@ -17,6 +17,7 @@ | |||
|
|
|||
| [package] | |||
| authors = { workspace = true } | |||
| description = "DataFusion sqllogictest driver" | |||
There was a problem hiding this comment.
Without this field publishing to crates.io failed like:
error: failed to publish to registry at https://crates.io
Caused by:
the remote server responded with an error (status 400 Bad Request): missing or empty metadata fields: description. Please see https://doc.rust-lang.org/cargo/reference/manifest.html for more information on configuring these fields
alamb
changed the title
xudong963
approved these changes
Jan 22, 2025
This was referenced Jan 23, 2025
xudong963
pushed a commit
to polygon-io/arrow-datafusion
that referenced
this pull request
Jan 27, 2025
…4233) * Minor: Add publishing datafusion-sqllogictest to release README.md * Add description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Other projects such as rust-iceberg would like to use the datafusion sqllogictest driver to write tests
The code is structured to be published as a crate, and is part of the official release tarballs. We just haven't previously published it to crates. io.
What changes are included in this PR?
Are these changes tested?
I tested it manually to publish previously approved releases
(I had to add the new description field to Cargo.toml)
They are now available on crates.io as well:
I also sent crate ownership invitations to match the existing datafusion crates
Are there any user-facing changes?
New crate on crates.io