Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract useful methods from sqllogictest bin #14267

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Conversation

xudong963
Copy link
Member

Which issue does this PR close?

Follow up #14233

Rationale for this change

During building the custom sqllogictest, I found these methods are also useful.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Jan 24, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks @xudong963

@alamb alamb merged commit f9696b6 into apache:main Jan 25, 2025
25 checks passed
@xudong963
Copy link
Member Author

Looks good to me -- thanks @xudong963

thanks!

@xudong963 xudong963 deleted the extract_util branch January 25, 2025 11:58
xudong963 added a commit to polygon-io/arrow-datafusion that referenced this pull request Jan 27, 2025
xudong963 added a commit to polygon-io/arrow-datafusion that referenced this pull request Jan 27, 2025
xudong963 added a commit to polygon-io/arrow-datafusion that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants