sdk: Bump all SDK crates for relaxed dependencies #4969
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
#### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from solana-labs#4661.
programs/bpf_loader/src/lib.rs
Outdated
| @@ -1336,6 +1336,7 @@ fn process_loader_upgradeable_instruction( | |||
| additional_bytes | |||
| ); | |||
| } | |||
| UpgradeableLoaderInstruction::Migrate => unimplemented!(), | |||
There was a problem hiding this comment.
This should return InstructionError::InvalidInstructionData. Can't merge any code into master that would cause a validator to panic
There was a problem hiding this comment.
Makes sense, done with 8eed5ab
| @@ -187,6 +187,7 @@ pub fn parse_bpf_upgradeable_loader( | |||
| }), | |||
| }) | |||
| } | |||
| UpgradeableLoaderInstruction::Migrate => unimplemented!(), | |||
There was a problem hiding this comment.
same here, this would cause rpc to panic. Return ParseInstructionError::InstructionNotParsable(ParsableProgram::BpfUpgradeableLoader) here instead
joncinque
added
automerge
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
* sdk: Bump all SDK crates for relaxed dependencies #### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from #4661. * Return errors instead of panicking (cherry picked from commit a1ed2b1)
* sdk: Bump all SDK crates for relaxed dependencies #### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from #4661. * Return errors instead of panicking (cherry picked from commit a1ed2b1)
…4969) (#4972) sdk: Bump all SDK crates for relaxed dependencies (#4969) * sdk: Bump all SDK crates for relaxed dependencies #### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from #4661. * Return errors instead of panicking (cherry picked from commit a1ed2b1) Co-authored-by: Jon C <[email protected]>
Problem
The SDK relaxed its internal dependencies in
anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions.
Summary of changes
Update all SDK crates to their next version. For almost all of them, that's v2.2.1
Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change.
To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from #4661.