Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.2: sdk: Bump all SDK crates for relaxed dependencies (backport of #4969) #4972

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 13, 2025

Problem

The SDK relaxed its internal dependencies in
anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions.

Summary of changes

Update all SDK crates to their next version. For almost all of them, that's v2.2.1

Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change.

To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from #4661.


This is an automatic backport of pull request #4969 done by Mergify.

@mergify mergify bot requested a review from a team as a code owner February 13, 2025 15:51
Copy link
Author

mergify bot commented Feb 13, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@joncinque
Copy link

This will need a rebase on #4946 once it lands

solana-loader-v3-interface = "=2.2.0"
solana-loader-v4-interface = "=2.2.0"
solana-loader-v2-interface = "=2.2.1"
solana-loader-v3-interface = "=3.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

* sdk: Bump all SDK crates for relaxed dependencies

#### Problem

The SDK relaxed its internal dependencies in
anza-xyz/solana-sdk#27, but the monorepo is
still using the pinned versions.

#### Summary of changes

Update all SDK crates to their next version. For almost all of them,
that's v2.2.1

Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and
the loader-v3-interface goes to v3.0.0 due to a breaking change.

To keep this PR small, the logic changes required for v3.0.0 are not
implemented, and must be done in follow-up work, which essentially means
reapplying the changes from #4661.

* Return errors instead of panicking

(cherry picked from commit a1ed2b1)
Copy link

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. thought i approved

@Lichtso Lichtso merged commit 8b11c7d into v2.2 Feb 14, 2025
46 checks passed
@Lichtso Lichtso deleted the mergify/bp/v2.2/pr-4969 branch February 14, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants