[Sprint] Fix missing switch in RelaxedRigidContacts compute_contact_forces
#356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flferretti
approved these changes
Jan 28, 2025
flferretti
reviewed
Jan 28, 2025
Co-authored-by: Filippo Luca Ferretti <[email protected]>
younik
approved these changes
Jan 29, 2025
CarlottaSartore
approved these changes
Jan 30, 2025
xela-95
changed the title
compute_contact_forcescompute_contact_forces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a missing switch of velocity representation inside the relaxed contact model, probably removed during the sprint.
📚 Documentation preview 📚: https://jaxsim--356.org.readthedocs.build//356/