Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRUM-249 initial commit of JSON test files for gene loading #43

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

markquintontulloch
Copy link
Member

Pseudocode for possible tests using these files can be found here:
https://docs.google.com/spreadsheets/d/1nT_4Avis361ymRZXv-QRhNn1G9n1htdZTxqLgcL_ZCM/edit?usp=sharing

00_mod_examples.json contains 605 gene entries from MOD-submitted BGI
files, representing all currently submitted combinations of fields.
Files 01-17 contain single gene entries, with 01-12 missing a single
field, and 13-17 containing invalid entries (although we currently do
not carry out data validation). File 18 contains 2 gene entries with
duplicate primaryId field values.

Pseudocode for possible tests using these files can be found here:
https://docs.google.com/spreadsheets/d/1nT_4Avis361ymRZXv-QRhNn1G9n1htdZTxqLgcL_ZCM/edit?usp=sharing

00_mod_examples.json contains 605 gene entries from MOD-submitted BGI
files, representing all currently submitted combinations of fields.
Files 01-17 contain single gene entries, with 01-12 missing a single
field, and 13-17 containing invalid entries (although we currently do
not carry out data validation).  File 18 contains 2 gene entries with
duplicate primaryId field values.
Copy link
Member

@chris-grove chris-grove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test files all look good to me!

@chris-grove chris-grove merged commit 1ab02c4 into main Sep 13, 2021
@chris-grove chris-grove deleted the SCRUM-249_JSON_test_files branch September 13, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants