Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source: LinkedinAds - Upgrade API Version to 202410 #52599

Merged
merged 23 commits into from
Feb 3, 2025

Conversation

agarctfi
Copy link
Contributor

@agarctfi agarctfi commented Jan 28, 2025

What

Internal PR for: #49458

This PR aims to solve the issue (#49457). It does this quite simply by upgrading the linkedin ads version of the creatives stream to the 202410 version. This is an important step of the Linkedin ads API with its long term objective to deprecate the endpoints InMailContents API or the AdDirectSponsoredContents API.

How

Upgrading the manifest.yaml file of the source connector.

Review guide

Will run regression and check CI tests

User Impact

User impacts only the creatives stream is only the addition of the name column. This can be confirmed here.

Can this PR be safely reverted and rolled back?

  • [ X] YES 💚
  • NO ❌

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 3:54pm

@agarctfi
Copy link
Contributor Author

agarctfi commented Feb 3, 2025

/approve-regression-tests

Check job output.

✅ Approving regression tests

Copy link
Contributor

@aldogonzalez8 aldogonzalez8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

@agarctfi agarctfi merged commit 7f8431f into master Feb 3, 2025
31 of 32 checks passed
@agarctfi agarctfi deleted the agarctfi/source-linkedin-ads/creative-upgrade branch February 3, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/linkedin-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants