Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrading linkedin ads api version for creatives stream #49458

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

FVidalCarneiro
Copy link
Contributor

@FVidalCarneiro FVidalCarneiro commented Dec 13, 2024

What

This PR aims to solve the issue (#49457). It does this quite simply by upgrading the linkedin ads version of the creatives stream to the 202410 version. This is an important step of the Linkedin ads API with its long term objective to deprecate the endpoints InMailContents API or the AdDirectSponsoredContents API.

How

Upgrading the manifest.yaml file of the source connector.

Review guide

  1. manifest.yaml

User Impact

User impacts only the creatives stream is only the addition of the name column. This can be confirmed here.

Can this PR be safely reverted and rolled back?

  • YES 💚 - however, the name field will no longer appear and will be removed from stream.
  • NO ❌

Copy link

vercel bot commented Dec 13, 2024

@FVidalCarneiro is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FVidalCarneiro thanks for update the connector. Update the connector version in the metadata.yaml and pyproject.toml files, also add an entry in the connector documentation for this change.

Would be possible to provide access to maintainers edit your branch? This is necessary to run tests, future format fixes and merging the contribution.

@natikgadzhi
Copy link
Contributor

Time for another rebase?

…ce-linkedin-ads-creatives-upgrade-feat

# Conflicts:
#	docs/integrations/sources/linkedin-ads.md
@kev-datams
Copy link
Contributor

kev-datams commented Jan 15, 2025

Time for another rebase?

hello @natikgadzhi @lazebnyi, all done ✅
please could you merge it 🙏
thanks a lot !

FYI @FVidalCarneiro

@kev-datams
Copy link
Contributor

This is quite frustrating not to have a validation for a such small PR

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are fine, but let's make this a progressive rollout just in case.

@marcosmarxm can you please work with @agarctfi to change the version tags here, and then merge and start a progressive rollout?

I'm happy to force-merge / approve when the version are set to RC correctly.

@kev-datams
Copy link
Contributor

Code changes are fine, but let's make this a progressive rollout just in case.

@marcosmarxm can you please work with @agarctfi to change the version tags here, and then merge and start a progressive rollout?

I'm happy to force-merge / approve when the version are set to RC correctly.

@natikgadzhi do you confirm we can not help you on this point ?

@kev-datams
Copy link
Contributor

hello, new conflict (again), how can we efficiently progress on this topic ? 🙏

@FVidalCarneiro
Copy link
Contributor Author

Hello @natikgadzhi , @marcosmarxm , @agarctfi , another merge conflict that we had to solve. Please try to merge this asap to avoid once again updating our branch. This is a very small change that has a business impact for us and that is taking the creatives endpoint to the direction required (as described in the PR description). We opened this small PR more than a month ago and are a bit frustrated to see it not advancing.

FYI, we believe the AdDirectSponsoredContents API has been silently already sunset by Linkedin. On our side, we are currently unable to collect creative names.

@PaulGrolleau
Copy link

PaulGrolleau commented Jan 29, 2025

Hello Everyone,

Thank you so much, @FVidalCarneiro and @kev-datams, for the adjustment! I was working on this earlier today and just came across your PR—great timing.

To the Airbyte team, is there any update on when this might be merged? It’s a valuable feature for my team, and I’m exploring options in the meantime.

Appreciate your efforts—thanks in advance!

ps: let me know if I can be of any help

@natikgadzhi
Copy link
Contributor

@agarctfi is fixing up another bug in linkedin ads, and then he'll get this merged — I expect it's this or next week.

@FVidalCarneiro
Copy link
Contributor Author

@natikgadzhi , I saw that the fix has been merged. Solved merge conflicts and ready to merge again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/linkedin-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants