-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add search by nft and shorten search placehodler #626
Conversation
Deployed to https://pr-626-aescan.stg.service.aepps.com |
IMG_0875.MP4
IMG_0876.MP4The same on web will get me a couple of names with 'next' in naming. |
I tried to implement another fix. Please check it now
It's something I need to request from MDW |
2023-12-19.2.27.12.movThe rest LGTM. |
Yes that's what I requested to change on MDW side. Applies for all entities in search
Ok, thanks. Will fix separately
I can take a look at this if it was a regression of this work. What is the account hash? |
@janmichek account hash ak_Cfr7h3XgjD6aScm3A96qMp2EF3p9Ao66gmVQvDEZAAsoCMGER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at my comments.
src/components/SearchNftsTable.vue
Outdated
<th> | ||
Symbol | ||
<hint-tooltip> | ||
{{ nftsHints.symbol }} | ||
</hint-tooltip> | ||
</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<th> | |
Symbol | |
<hint-tooltip> | |
{{ nftsHints.symbol }} | |
</hint-tooltip> | |
</th> |
I would remove the "Symbol" column to keep it consistent with the NFTs page where we don't have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
e571597
to
7bbbaaa
Compare
Fixed by rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
Description
fixes #420
fixes #338
fixes #492
Demo
firefox_VxqfXMbZ0h.mp4
Checklist: