-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add search by nft and shorten search placehodler #624
Conversation
Deployed to https://pr-624-aescan.stg.service.aepps.com |
@@ -1,7 +1,23 @@ | |||
export const nftsHints = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were 2 files for NFT hints. Probably product of some merging. I united it into just one. Hence every nft hint should also be checked @Liubov-crypto
@@ -3,7 +3,7 @@ | |||
<input | |||
v-model="query" | |||
class="search-bar__input" | |||
placeholder="Search accounts, transactions, names, contracts, oracles, state channels, keyblocks, and microblocks" | |||
placeholder="Search anything on aeScan" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the zooming issue on iPhone @Liubov-crypto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the zooming issue on iPhone @Liubov-crypto
Still reproducible for me on iPhone 13 in Safari browser ver. 17.1.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to apply possible fix. Please try again now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that search for NFT by name is not accurate. For example, if I'm searching for 'cool' nft I will receive only 1 result for nft, but we have 2 nft with such name - cool cat and coolcat.
@janmichek please check it:
2023-12-15.1.35.30.mov
Also, zooming on iphone still reproducible for me.
That's a known bug. The search is case sensitive currently. The fix is requested from mdw |
Build stopped working for unknown reason |
Moved here #626 |
Description
fixes #420
fixes #338
fixes #492
Demo
firefox_VxqfXMbZ0h.mp4
Checklist: