Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add search by nft and shorten search placehodler #624

Closed
wants to merge 3 commits into from

Conversation

janmichek
Copy link
Collaborator

Description

fixes #420
fixes #338
fixes #492

Demo

firefox_VxqfXMbZ0h.mp4

Checklist:

  • I have read and followed the Contributing Guide
  • fix nft hints
  • add search by nft
  • shorten placeholder

Copy link

@@ -1,7 +1,23 @@
export const nftsHints = {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were 2 files for NFT hints. Probably product of some merging. I united it into just one. Hence every nft hint should also be checked @Liubov-crypto

@@ -3,7 +3,7 @@
<input
v-model="query"
class="search-bar__input"
placeholder="Search accounts, transactions, names, contracts, oracles, state channels, keyblocks, and microblocks"
placeholder="Search anything on aeScan"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the zooming issue on iPhone @Liubov-crypto

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the zooming issue on iPhone @Liubov-crypto

Still reproducible for me on iPhone 13 in Safari browser ver. 17.1.2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to apply possible fix. Please try again now

Copy link

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that search for NFT by name is not accurate. For example, if I'm searching for 'cool' nft I will receive only 1 result for nft, but we have 2 nft with such name - cool cat and coolcat.

@janmichek please check it:

2023-12-15.1.35.30.mov

Also, zooming on iphone still reproducible for me.

@janmichek
Copy link
Collaborator Author

@Liubov-crypto

It seems that search for NFT by name is not accurate. For example, if I'm searching for 'cool' nft I will receive only 1 result for nft, but we have 2 nft with such name - cool cat and coolcat.

That's a known bug. The search is case sensitive currently. The fix is requested from mdw

@janmichek
Copy link
Collaborator Author

Build stopped working for unknown reason

@janmichek janmichek closed this Dec 15, 2023
@janmichek
Copy link
Collaborator Author

Moved here #626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search by NFT Search field placeholder text is too long Input gets zoomed upon initialization of the page
2 participants