DCXY-20504: Don't pre-render dropzone when l2 limit is hit and upsell is shown #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peller
reviewed
Nov 21, 2023
peller
reviewed
Nov 21, 2023
peller
reviewed
Nov 21, 2023
Co-authored-by: Adam Peller <[email protected]>
…nd returning user check anymore
peller
reviewed
Nov 22, 2023
peller
reviewed
Nov 22, 2023
Co-authored-by: Adam Peller <[email protected]>
peller
approved these changes
Nov 30, 2023
… potentially adding exh cookie that acom reads. This should be retired once both of their app ids are unified.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #489 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 26 26
Lines 2878 2895 +17
=======================================
+ Hits 2862 2879 +17
Misses 16 16 ☔ View full report in Codecov by Sentry. |
|
Thank you both for the review. |
peller
reviewed
Dec 1, 2023
TsayAdobe
approved these changes
Dec 1, 2023
peller
reviewed
Dec 1, 2023
Comment on lines
117
to
121
| 'to-pdf': 'p_ac_cr_p_c', | ||
| 'pdf-to': 'p_ac_ex_p_c', | ||
| 'compress-pdf': 'p_ac_cm_p_ops', | ||
| 'rotate-pages': 'p_ac_or_p_c', | ||
| createpdf: 'p_ac_cr_p_c', |
There was a problem hiding this comment.
hate to add more logic but we should use p_ s_ and d_ for prod, stage and dev, respectively. Perhaps remove the p_ from this map and prepend the right prefix to limitCookie at L220
There was a problem hiding this comment.
No worries, makes sense. Updated
peller
changed the title
peller
reviewed
Dec 4, 2023
peller
reviewed
Dec 5, 2023
Co-authored-by: Adam Peller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is shown.