DCXY-19397: Don't pre-render dropzone when l2 limit is hit and upsell is shown #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Adam Peller <[email protected]>
…nd returning user check anymore
Co-authored-by: Adam Peller <[email protected]>
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## stage #490 +/- ##
==========================================
- Coverage 99.44% 99.34% -0.11%
==========================================
Files 26 26
Lines 2878 2894 +16
==========================================
+ Hits 2862 2875 +13
- Misses 16 19 +3 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -113,7 +113,17 @@ const verbRedirMap = { | |||
| 'number-pages': 'number', | |||
| }; | |||
|
|
|||
| const exhLimitCookieMap = { | |||
| 'createpdf': 'cr_p_c_e', | |||
There was a problem hiding this comment.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'createpdf' found.
Suggested change
| 'createpdf': 'cr_p_c_e', | |
| createpdf: 'cr_p_c_e', |
|
|
closing in favor of #489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DC Web will keep a set of cookies for when a limit has been reached. We can check this cookie to predict whether an upsell will be shown and only pre-render the dropzone if that cookie is not set.
merged from kbenelli-adobe:DCXY-19397-New
@kbenelli-adobe