feat: material maps #557
Merged
feat: material maps #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
niermann999
force-pushed
the
feat-material-maps
branch
3 times, most recently
from
946b8e8 to
fe970a5
Compare
niermann999
force-pushed
the
feat-material-maps
branch
3 times, most recently
from
7f498fb to
d6eb700
Compare
niermann999
added
enhancement
niermann999
force-pushed
the
feat-material-maps
branch
4 times, most recently
from
f53a2bb to
901e8f9
Compare
niermann999
force-pushed
the
feat-material-maps
branch
2 times, most recently
from
ed1e418 to
7fe1c2e
Compare
niermann999
force-pushed
the
feat-material-maps
branch
7 times, most recently
from
947db56 to
ed76a26
Compare
niermann999
force-pushed
the
feat-material-maps
branch
from
ed76a26 to
649a818
Compare
|
This still needs to be followed up by adding optional maps to sensitive surfaces and IO, so that the material scan works nicely. Until then, the maps that are generated are largely not validated |
niermann999
force-pushed
the
feat-material-maps
branch
from
649a818 to
b4f93ff
Compare
detector metadata. The material maps of different shapes are tested in a dedicated unittest. Material maps are added to the toy detector and wire chamber via the detector helper. The material is a silicon and aluminium mixture that is mapped in configurable binning onto the disc and cylinder portals.
beomki-yeo
reviewed
Nov 15, 2023
beomki-yeo
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add material grids as material maps and add the relevant types to the
detector metadata. The material maps of different shapes are tested
in a dedicated unittest.
Material maps are added to the toy detector and wire chamber via
the detector helper. The material is a silicon and aluminium mixture
that is mapped in configurable binning onto the disc and cylinder
portals.