Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: material maps writer #587

Merged
merged 1 commit into from
Nov 17, 2023
Merged

feat: material maps writer #587

merged 1 commit into from
Nov 17, 2023

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Nov 9, 2023 •
edited
Loading

This implements the material maps writing. It splits the common writer functionality for the grids in a common helper class that is inherited by the surface_grid_writer and the new material_map_writer. The material_map_writer uses the grid_payload with a material_slab_payload as value type.

@niermann999 niermann999 force-pushed the feat-material-maps-io branch from 1f03c5a to e0f6ce5 Compare November 10, 2023 12:37
@niermann999 niermann999 changed the title feat material maps io feat: material maps writer Nov 10, 2023
@niermann999 niermann999 added enhancement New feature or request refactor refactoring the current codes priority: high high priority blocked This item is blocked by another item labels Nov 10, 2023
@niermann999
Copy link
Contributor Author

niermann999 commented Nov 10, 2023 •
edited
Loading

Based on #557

@niermann999 niermann999 marked this pull request as ready for review November 10, 2023 12:41
@niermann999 niermann999 force-pushed the feat-material-maps-io branch 3 times, most recently from abc3816 to f9644af Compare November 16, 2023 14:59
@niermann999 niermann999 removed the blocked This item is blocked by another item label Nov 16, 2023
@niermann999 niermann999 force-pushed the feat-material-maps-io branch from f9644af to 5631002 Compare November 16, 2023 15:14
beomki-yeo
beomki-yeo approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@niermann999 niermann999 force-pushed the feat-material-maps-io branch from 5631002 to 8aebb03 Compare November 17, 2023 10:24
@niermann999
This implements the material maps writing. It splits the common writer
8e3b8a6 
functionality for the grids in a common helper class that is inherited
by the surface_grid_writer and the new material_map_writer.
The material_map_writer uses the grid_payload with a material_slab_payload
as value type.
@niermann999 niermann999 force-pushed the feat-material-maps-io branch from 8aebb03 to 8e3b8a6 Compare November 17, 2023 10:25
@niermann999 niermann999 merged commit 60b02a8 into acts-project:main Nov 17, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beomki-yeo beomki-yeo beomki-yeo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request priority: high high priority refactor refactoring the current codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niermann999 @beomki-yeo