Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: static_cast step direction to avoid compiler warning #375

Merged
merged 1 commit into from
Jan 24, 2023
Merged

fix: static_cast step direction to avoid compiler warning #375

merged 1 commit into from
Jan 24, 2023

Conversation

niermann999
Copy link
Contributor

Add static cast to step direction to silence compiler warning when compiling c++ 20

@niermann999 niermann999 mentioned this pull request Jan 24, 2023
Closed
@niermann999 niermann999 added the bug Something isn't working label Jan 24, 2023
@niermann999 niermann999 linked an issue Jan 24, 2023 that may be closed by this pull request
Deprecated arithmetic between enumeration and floating point types #374
Closed
stephenswat
stephenswat approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the quick fix.

@niermann999
Copy link
Contributor Author

Does that fix the warning for you?

@stephenswat
Copy link
Member

It seems to, yes.

@niermann999 niermann999 merged commit c1b6f0d into acts-project:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenswat stephenswat stephenswat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated arithmetic between enumeration and floating point types
2 participants
@niermann999 @stephenswat