Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated arithmetic between enumeration and floating point types #374

Closed
stephenswat opened this issue Jan 24, 2023 · 1 comment · Fixed by #375
Closed

Deprecated arithmetic between enumeration and floating point types #374

stephenswat opened this issue Jan 24, 2023 · 1 comment · Fixed by #375
Assignees
Labels
bug Something isn't working

Comments

@stephenswat
Copy link
Member

Dear detray developers, while trying to compile traccc with C++20 enabled I encountered an issue stemming from detray, namely that deprecated arithmetic between enumeration and floating point types is used here:

Please consider adding static casts to turn this enumeration type into a floating point type, or use a conditional to multiply without relying on implicit conversion.

@stephenswat stephenswat added the bug Something isn't working label Jan 24, 2023
@niermann999 niermann999 self-assigned this Jan 24, 2023
@niermann999
Copy link
Contributor

This is related to #337 and will need to be rewritten at some point. Unsigned integer to floating point conversions will be cleaned out in #372 . But for this particular issue, see #375 for a quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants